Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update src/CMakeLists.txt: use modern cmake features to install Fortran modules in the correct place #653

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Mar 18, 2025

Update src/CMakeLists.txt: use modern cmake features to install Fortran modules in the correct place

Update CMakeLists.txt to modern cmake version 3 and support NEPTUNE cmake build while retaining compatibility with UFS/SCM

User interface changes?: No

Fixes: [Github issue #s] n/a

Testing: all CI tests pass, ran capgen and prebuild tests locally on my laptop - all pass
test removed:
unit tests:
system tests:
manual testing:

Associated PRs:

…an modules in the correct place (NCAR#4)

Update CMakeLists.txt to:
- Bring in updates from NCAR ccpp-framework main as needed and update CMakeLists.txt to modern cmake version 3
- Support NEPTUNE cmake build while retaining compatibility with UFS/SCM
@climbfuji climbfuji changed the title Update src/CMakeLists.txt: use modern cmake features to install Fortr… Update src/CMakeLists.txt: use modern cmake features to install Fortran modules in the correct place Mar 18, 2025
@climbfuji climbfuji marked this pull request as ready for review March 18, 2025 13:59
@dustinswales
Copy link
Collaborator

@climbfuji Thanks for updating and modernizing the cmake file.
Have you tested in the UFS?

@climbfuji
Copy link
Collaborator Author

@climbfuji Thanks for updating and modernizing the cmake file. Have you tested in the UFS?

No, neither this nor the corresponding ccpp-physics PR NCAR/ccpp-physics#1119

I can do the tests this week.

@dustinswales
Copy link
Collaborator

I opened a PR into the SCM with these and the physics changes for testing via CI, NCAR/ccpp-scm#568

@climbfuji
Copy link
Collaborator Author

I opened a PR into the SCM with these and the physics changes for testing via CI, NCAR/ccpp-scm#568

Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants