-
Notifications
You must be signed in to change notification settings - Fork 45
Py_Modify #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mforootan
wants to merge
2,189
commits into
NCIP:develop
Choose a base branch
from
NCI-GDC:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Py_Modify #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mforootan
commented
Jan 27, 2021
- Make a new branch of gdc-docs, and modify any Python script that currently just prints to console so that it writes to a file.
- Add remarks explaining what the script does to the beginning of all of them (pretty much copy-pasting what's already in the documentation page into the script box).
- Make the sample file examples executable (so the user can simply copy-paste scripts, run, and see some output), as much as possible (using real examples); or clearly explain required changes.
Co-authored-by: Bill Wysocki <[email protected]>
Co-authored-by: Bill Wysocki <[email protected]>
Moving WGS information from the WXS documentation
Editing mkdocs
Portal vid - Add to tutorial page
Draft of DR42 Release Notes
Co-authored-by: Bill Wysocki <[email protected]>
Co-authored-by: Bill Wysocki <[email protected]>
Co-authored-by: Bill Wysocki <[email protected]>
Rearranged order and removed WGS variant project list
Co-authored-by: Bill Wysocki <[email protected]>
Co-authored-by: Bill Wysocki <[email protected]>
Co-authored-by: Bill Wysocki <[email protected]>
Co-authored-by: Bill Wysocki <[email protected]>
Co-authored-by: Bill Wysocki <[email protected]>
DR42 Release Notes
Changing dashes to asterisks
WGS Variant Documentation
…e_notes DOC-472 adds cohort comparison negative cases info
encoding fix
Attempting to fix encoding issues (no exact position provided in terminal output)
Fixing encoding issues
curly quote
-Removed all "Changes made to 'properties' " and backtabbed lines below -Removed all "Removed property: `deprecated` " -Removed "Removed property: `deprecated_enum` " (line 212) -Removed "Changes made to `deprecated_enum` " (Line 207) -Tabbed `weeks_gestation_at_birth` (Line 45)
-Removed 'deprecated' (line 132) -Deprecated format fixed for family_history (line 52)
-Edits to 'deprecated' sections -Removed properties that were "undeprecated"
Updated dates
Update Data_Dictionary_Release_Notes.md
- Family_history.relationship_sex_at_birth changed to `new` - Family_history.relationship_gender changed to `deprecated` - Diagnosis properties removed from pathology_detail - `morphology` moved to diagnosis - Follow_up.days_to_first_event removed from changelist - Removed analyte.analyte_type_id from changelist - `After Study Enrollment` and `Prior to Study Enrollment` added to timepoint_category as deprecated - 9385/3 and 9478/3 added as new morphology values - Removed 'deprecated' from follow_up entity - Added 'indeterminant' as a deprecated value to margin_status
Added the four removed properties to diagnosis
Moved `micropapillary_features`, `papillary_renal_cell_type` under diagnosis as removed
Update Data_Dictionary_Release_Notes.md
PEAR-2395 - Dictionary viewer, hide deprecated enums
PEAR-2415 - Dictionary Viewer “Center”, “Program” & “Tissue Source Site” nodes aren't loading for some scenarios
PEAR-2481 - Add breadcrumbs back to dictionary viewer
Added release notes and file list
changed file suffix to correct one
Added scRNA Tool - Video Tutorial
Embed link
…_links DOC-488: Updating outdated links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.