Cleanup Storage usage #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
linkdotnet
approved these changes
Feb 6, 2025
nulltoken
force-pushed
the
ntk/storage
branch
2 times, most recently
from
114e926 to
4d15886
Compare
|
@linkdotnet I'll complete this one when I'm happy with #199 (as it depends on this one to counter some time related concurrency issues). |
nulltoken
commented
Feb 6, 2025
nulltoken
force-pushed
the
ntk/storage
branch
from
4d15886 to
186d34c
Compare
|
Still LGTM - feel free to merge ;) |
nulltoken
force-pushed
the
ntk/storage
branch
2 times, most recently
from
acf2b34 to
84d6412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Low hanging fruit on the journey to make maintenance of tests a bit easier
PR meta checklist
mainbranch for codeCode PR specific checklist