Merged
Conversation
Update InputDateTime to include option to display full format value below Update publish script to include verify step
2 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the InputDateTime component by introducing an option to display the full formatted value below the input and updating the publish script to include a verification step.
- Added a new method GetFullDisplayValue in InputDateTime.razor.cs to support full date/time display.
- Updated the GitHub Actions publish workflow to verify the signed NuGet package and adjusted the package filename casing.
- Updated the demo page TestDateTime.razor and enum definitions to incorporate the new display option.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| easy-blazor-bulma/Bulma/Form/InputDateTime.razor.cs | Introduces GetFullDisplayValue and simplifies FormatDateOnly conversion. |
| .github/workflows/publish.yml | Updates the NuGet package signing command for consistent naming and adds a package verification step. |
| easy-blazor-bulma/Enums/InputDateTimeOptions.cs | Adds the new ShowFullValueBelow option for full date/time display. |
| easy-blazor-bulma-demo/Components/Pages/Forms/TestDateTime.razor | Adjusts option usage in the demo for date-only and full date display tests. |
| easy-blazor-bulma/Bulma/Form/InputDateTime.razor | Adds conditional rendering for the full display value below the input. |
Files not reviewed (1)
- easy-blazor-bulma/easy-blazor-bulma.csproj: Language not supported
Comments suppressed due to low confidence (2)
easy-blazor-bulma/Bulma/Form/InputDateTime.razor.cs:361
- Consider wrapping the type conversion operations (using Convert.ChangeType) in a try-catch block to handle potential conversion exceptions gracefully, ensuring the component remains robust if CurrentValue is not in the expected format.
if (Options.HasFlag(InputDateTimeOptions.ShowFullValueBelow) == false || Value == null)
.github/workflows/publish.yml:61
- The filename casing has changed from 'easy-blazor-bulma' to 'Easy-Blazor-Bulma'; verify that this change is consistent with the package naming conventions and file system case sensitivity across deployment environments.
NuGetKeyVaultSignTool sign ${{ env.NuGetDirectory }}/Easy-Blazor-Bulma.${{ github.event.release.tag_name }}.nupkg --file-digest sha256 --timestamp-rfc3161 http://timestamp.sectigo.com --timestamp-digest sha256 --azure-key-vault-url ${{ vars.AZURE_KEY_VAULT }} --azure-key-vault-tenant-id ${{ secrets.AZURE_TENANT_ID }} --azure-key-vault-client-id ${{ secrets.AZURE_CLIENT_ID }} --azure-key-vault-client-secret "${{ secrets.AZURE_CLIENT_SECRET }}" --azure-key-vault-certificate ${{ vars.AZURE_CODE_SIGN_CERTIFICATE }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update InputDateTime to include option to display full format value below Update publish script to include verify step