Debug command to expose the last and next moments that XFR will be attempted. - #963
Open
ximon18 wants to merge 2 commits into
Open
Debug command to expose the last and next moments that XFR will be attempted.#963ximon18 wants to merge 2 commits into
ximon18 wants to merge 2 commits into
Conversation
And whether that attempt will be a normal refresh or a retry.
Member
|
Nice. I think there should be an entry in the documentation. We experiment with these features and later see if it should move to zone status or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is something that keeps bugging me: I can't tell from Cascade when it is going to try an upstream XFR next, and whether that will be a normal attempt or a retry.
I don't think this is something a user should ever need to normally care about, so I wondered about exposing it via a debug command, hence this PR.
I have not put any effort into styling the output at this point as I want to know first if anyone else sees value in this.
I would also like to extend this to show the set of available IXFR diffs in memory that can be served to downstream clients.
Example output:
Another way to approach this could be to expose this via metrics, e.g. last refresh time and whether or not the last refresh was successful or not.
It could also just be shown as part of
zone statusbut we're trying to keep that fairly minimal. It could also be added tozone status --detailedbut I think we should keep that to things operators really need to know, and this feels more like diagnostics in case of an unexpected problem or an aid when debugging/testing.Yet another idea: perhaps this should be considered part of the missing information we want to show about "what is going to happen next" for a zone?
If you are changing Rust code or integration tests (
Cargo.*,crates/,etc/,integration-tests/,src/):actthrough theact-wrapper(as described inTESTING.md)?If you are modifying man pages: