Limit the conditions for zone removal - #968
Open
bal-e wants to merge 6 commits into
Open
Conversation
| Remove a zone. | ||
| .sp | ||
| Maintenance mode must be enabled (see \fBzone maintenance\fP). The | ||
| zone must be passive (with no ongoing operations) or in a hard\-halt state. |
Member
There was a problem hiding this comment.
Is this or? I thought maintenance mode was always required.
Contributor
Author
There was a problem hiding this comment.
Oh, right, forgot to update the docs. On it.
| // The zone must be in maintenance mode, and passive/halted. | ||
| // TODO(#871): support removing a zone during restoration. | ||
| if !zone.maintenance_mode || !zone.machine.is_waiting() && !zone.machine.is_halted() { | ||
| return Err(ZoneRemoveError::NotInMaintenanceMode); |
Member
There was a problem hiding this comment.
This might be confusing if the zone is in maintenance mode but not waiting or halted
Contributor
Author
There was a problem hiding this comment.
Yeah, the confusion originates from the terminology we use for maintenance mode; e.g. cascade zone maintenance enable sets a flag, but maintenance mode only really takes effect when Cascade reaches the waiting state. I think this needs a broader discussion.
ximon18
added
UX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't have a good way to cancel ongoing operations, so if a zone is removed in the middle of an operation, the operation is likely to crash. This PR gates zone removal behind maintenance mode, and requires the zone to be passive or hard-halted.
While updating the documentation, I noticed that
cascade zone maintenancewas missing a section, so I added that too.Fixes #888.
If you are changing Rust code or integration tests (
Cargo.*,crates/,etc/,integration-tests/,src/):actthrough theact-wrapper(as described inTESTING.md)?If you are modifying man pages: