Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NXNAME RR type and invalid query type EDE #392

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

mworsley-cloudflare
Copy link
Contributor

@mworsley-cloudflare mworsley-cloudflare commented Sep 16, 2024

Adding NXNAME resource record type and the EDE code to reject invalid queries for it
EDE 30 and NXNAME are both IANA reserved

@AlexanderBand AlexanderBand requested a review from a team September 16, 2024 10:40
@Philip-NLnetLabs
Copy link
Member

Did something go wrong? IANA class it 'NXNAME', the PR seems to have NXDOMAIN?

@mworsley-cloudflare
Copy link
Contributor Author

Did something go wrong? IANA class it 'NXNAME', the PR seems to have NXDOMAIN?

You're 100% right, it should be NXNAME to match the IANA reserved

src/base/iana/exterr.rs Outdated Show resolved Hide resolved
@mworsley-cloudflare
Copy link
Contributor Author

Hi there, is there anything else the team would like out of this PR?

src/base/iana/exterr.rs Outdated Show resolved Hide resolved
@ximon18
Copy link
Member

ximon18 commented Sep 25, 2024

I notice that https://datatracker.ietf.org/doc/draft-ietf-dnsop-compact-denial-of-existence/ has not yet finished moving through the IETF process nor has the RFC been updated yet to reflect the new IANA EDE code point. Given that the IANA code point has now been allocated (at least it appears at https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml#extended-dns-error-codes) I assume it is low risk to merge this PR while the IETF process is ongoing.

@mworsley-cloudflare
Copy link
Contributor Author

I notice that https://datatracker.ietf.org/doc/draft-ietf-dnsop-compact-denial-of-existence/ has not yet finished moving through the IETF process nor has the RFC been updated yet to reflect the new IANA EDE code point. Given that the IANA code point has now been allocated (at least it appears at https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml#extended-dns-error-codes) I assume it is low risk to merge this PR while the IETF process is ongoing.

This is our assumption as well given that they've been allocated, in the small chance that anything changes I'll be back

@Chreo
Copy link

Chreo commented Oct 2, 2024

https://datatracker.ietf.org/doc/draft-ietf-dnsop-compact-denial-of-existence/ is in the final stages for RFC publication and while that may still result in changes to the final document, the allocation of the NXNAME type and the new EDE code is not going to be changed so is safe to import. IANA does not have a habit of changing allocated types meaning that worst case the allocated code point is burned and considered deprecated in the future.
Anything marked as allocated on https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml can be considered stable and not subject to rash changes.
It would be very useful to get this merged.

@ximon18 ximon18 merged commit 7ba4b71 into NLnetLabs:main Oct 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants