-
Notifications
You must be signed in to change notification settings - Fork 25
Add QC filters for radar reflectivity to align with GSI #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QC filters for radar reflectivity to align with GSI #522
Conversation
|
PS: I cannot add @daviddowellNOAA as a reviewer but I want to tag him so that he is aware of this PR. |
delippi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
|
@daviddowellNOAA is added as Outside Collaborator to this repo. |
|
PASSED on wcoss2 started build_and_test on wcoss2 at UTC time: Tue Jan 13 18:55:52 UTC 2026 workdir: /lfs/h2/emc/da/noscrub/samuel.degelia/rrfsbot/PRs_RDASApp/522 |
|
PASSED on hera started build_and_test on hera at UTC time: Tue Jan 13 21:25:02 UTC 2026 workdir: /scratch3/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/522 |
Description
This PR adds several observation-space filters for radar reflectivity in UFO that align with the quality control logic currently used in GSI. These new filters include:
omb/4.0where error ratio > 4 (corresponding GSI code)After making these updates, the fv3-jedi increments for Hybrid 3DEnVar are very close to GSI (see slide 35 here). The final observation counts are also very similar. Here are counts for the 2024050601 cycle from rrfs-workflow:
The different number of obs being read in is due to the built in domain check in GSI (here). Those differences get propagated into the ~250 ob difference for those passing QC.
Thanks for @daviddowellNOAA for pointing me to the updated error inflation codes in GSI! Also thanks to @delippi for some ideas on how to add the filters.
Issue(s) addressed
None
Dependencies (if applicable)
None
Checklist