Skip to content

Conversation

@SamuelDegelia-NOAA
Copy link
Contributor

@SamuelDegelia-NOAA SamuelDegelia-NOAA commented Jan 13, 2026

Description

This PR adds several observation-space filters for radar reflectivity in UFO that align with the quality control logic currently used in GSI. These new filters include:

After making these updates, the fv3-jedi increments for Hybrid 3DEnVar are very close to GSI (see slide 35 here). The final observation counts are also very similar. Here are counts for the 2024050601 cycle from rrfs-workflow:

GSI: 192,328 read, 176,509 pass
JEDI: 192,039 read, 176,241 pass

The different number of obs being read in is due to the built in domain check in GSI (here). Those differences get propagated into the ~250 ob difference for those passing QC.

Thanks for @daviddowellNOAA for pointing me to the updated error inflation codes in GSI! Also thanks to @delippi for some ideas on how to add the filters.

Issue(s) addressed

None

Dependencies (if applicable)

None

Checklist

  • I have performed a self-review of my own code.
  • I have run rrfs tests before creating the PR (if applicable).

@SamuelDegelia-NOAA
Copy link
Contributor Author

PS: I cannot add @daviddowellNOAA as a reviewer but I want to tag him so that he is aware of this PR.

Copy link
Collaborator

@delippi delippi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@ShunLiu-NOAA
Copy link

@daviddowellNOAA is added as Outside Collaborator to this repo.

@SamuelDegelia-NOAA
Copy link
Contributor Author

PASSED on wcoss2

started build_and_test on wcoss2 at UTC time: Tue Jan 13 18:55:52 UTC 2026
finished at UTC time: Tue Jan 13 20:02:55 UTC 2026

Test project /lfs/h2/emc/da/noscrub/samuel.degelia/rrfsbot/PRs_RDASApp/522/build/rrfs-test
      Start  6: rrfs_fv3jedi_2024052700_getkf_observer
      Start 15: rrfs_mpasjedi_2024052700_getkf_observer
      Start  1: rrfs_fv3jedi_2024052700_3dvar
      Start  2: rrfs_fv3jedi_2024052700_3denvar
      Start  3: rrfs_fv3jedi_2024052700_3denvar_mgbf
      Start  4: rrfs_fv3jedi_2024052700_hybrid3denvar
      Start  5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf
      Start  8: rrfs_fv3jedi_2024052700_3dvar_conv_surface
      Start  9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair
      Start 10: rrfs_fv3jedi_2024052700_3dvar_remote
 1/17 Test #10: rrfs_fv3jedi_2024052700_3dvar_remote ..........   Passed   79.83 sec
      Start 11: rrfs_fv3jedi_2024052700_3dvar_satrad
 2/17 Test  #1: rrfs_fv3jedi_2024052700_3dvar .................   Passed   95.92 sec
      Start 12: rrfs_fv3jedi_2024052700_3denvar_refl
 3/17 Test  #9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair ...   Passed  106.82 sec
      Start 13: rrfs_mpasjedi_2024052700_bumploc
 4/17 Test  #8: rrfs_fv3jedi_2024052700_3dvar_conv_surface ....   Passed  108.84 sec
      Start 14: rrfs_mpasjedi_2024052700_3denvar
 5/17 Test  #6: rrfs_fv3jedi_2024052700_getkf_observer ........   Passed  170.98 sec
      Start  7: rrfs_fv3jedi_2024052700_getkf_solver
 6/17 Test #11: rrfs_fv3jedi_2024052700_3dvar_satrad ..........   Passed  133.01 sec
      Start 17: rrfs_bufr2ioda_msonet
 7/17 Test #17: rrfs_bufr2ioda_msonet .........................   Passed   35.65 sec
 8/17 Test  #2: rrfs_fv3jedi_2024052700_3denvar ...............   Passed  270.95 sec
 9/17 Test  #4: rrfs_fv3jedi_2024052700_hybrid3denvar .........   Passed  276.92 sec
10/17 Test  #7: rrfs_fv3jedi_2024052700_getkf_solver ..........   Passed  208.87 sec
11/17 Test  #3: rrfs_fv3jedi_2024052700_3denvar_mgbf ..........   Passed  418.86 sec
12/17 Test  #5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf ....   Passed  444.81 sec
13/17 Test #13: rrfs_mpasjedi_2024052700_bumploc ..............   Passed  344.04 sec
14/17 Test #15: rrfs_mpasjedi_2024052700_getkf_observer .......   Passed  471.83 sec
      Start 16: rrfs_mpasjedi_2024052700_getkf_solver
15/17 Test #14: rrfs_mpasjedi_2024052700_3denvar ..............   Passed  462.98 sec
16/17 Test #16: rrfs_mpasjedi_2024052700_getkf_solver .........   Passed  370.00 sec
17/17 Test #12: rrfs_fv3jedi_2024052700_3denvar_refl ..........   Passed  1116.91 sec

100% tests passed, 0 tests failed out of 17

Label Time Summary:
rdas-bundle    = 5117.22 sec*proc (17 tests)
script         = 5117.22 sec*proc (17 tests)

Total Test time (real) = 1212.86 sec

workdir: /lfs/h2/emc/da/noscrub/samuel.degelia/rrfsbot/PRs_RDASApp/522

@rrfsbot
Copy link
Collaborator

rrfsbot commented Jan 13, 2026

PASSED on hera

started build_and_test on hera at UTC time: Tue Jan 13 21:25:02 UTC 2026
finished at UTC time: Tue Jan 13 21:55:06 UTC 2026

Test project /scratch3/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/522/build/rrfs-test
      Start  6: rrfs_fv3jedi_2024052700_getkf_observer
      Start 15: rrfs_mpasjedi_2024052700_getkf_observer
      Start  1: rrfs_fv3jedi_2024052700_3dvar
      Start  2: rrfs_fv3jedi_2024052700_3denvar
      Start  3: rrfs_fv3jedi_2024052700_3denvar_mgbf
      Start  4: rrfs_fv3jedi_2024052700_hybrid3denvar
      Start  5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf
      Start  8: rrfs_fv3jedi_2024052700_3dvar_conv_surface
 1/17 Test  #1: rrfs_fv3jedi_2024052700_3dvar .................   Passed   40.76 sec
      Start  9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair
 2/17 Test  #8: rrfs_fv3jedi_2024052700_3dvar_conv_surface ....   Passed   56.99 sec
      Start 10: rrfs_fv3jedi_2024052700_3dvar_remote
 3/17 Test  #6: rrfs_fv3jedi_2024052700_getkf_observer ........   Passed   82.24 sec
      Start  7: rrfs_fv3jedi_2024052700_getkf_solver
 4/17 Test #10: rrfs_fv3jedi_2024052700_3dvar_remote ..........   Passed   30.41 sec
      Start 11: rrfs_fv3jedi_2024052700_3dvar_satrad
 5/17 Test  #9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair ...   Passed   48.45 sec
      Start 12: rrfs_fv3jedi_2024052700_3denvar_refl
 6/17 Test #11: rrfs_fv3jedi_2024052700_3dvar_satrad ..........   Passed   67.66 sec
      Start 13: rrfs_mpasjedi_2024052700_bumploc
 7/17 Test  #7: rrfs_fv3jedi_2024052700_getkf_solver ..........   Passed   74.23 sec
      Start 14: rrfs_mpasjedi_2024052700_3denvar
 8/17 Test  #2: rrfs_fv3jedi_2024052700_3denvar ...............   Passed  167.28 sec
      Start 17: rrfs_bufr2ioda_msonet
 9/17 Test #17: rrfs_bufr2ioda_msonet .........................   Passed   24.45 sec
10/17 Test #15: rrfs_mpasjedi_2024052700_getkf_observer .......   Passed  207.63 sec
      Start 16: rrfs_mpasjedi_2024052700_getkf_solver
11/17 Test  #4: rrfs_fv3jedi_2024052700_hybrid3denvar .........   Passed  231.21 sec
12/17 Test  #3: rrfs_fv3jedi_2024052700_3denvar_mgbf ..........   Passed  236.67 sec
13/17 Test  #5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf ....   Passed  242.74 sec
14/17 Test #16: rrfs_mpasjedi_2024052700_getkf_solver .........   Passed  170.26 sec
15/17 Test #14: rrfs_mpasjedi_2024052700_3denvar ..............   Passed  265.70 sec
16/17 Test #13: rrfs_mpasjedi_2024052700_bumploc ..............   Passed  309.93 sec
17/17 Test #12: rrfs_fv3jedi_2024052700_3denvar_refl ..........   Passed  437.70 sec

100% tests passed, 0 tests failed out of 17

Label Time Summary:
mpi            = 2694.31 sec*proc (17 tests)
rdas-bundle    = 2694.31 sec*proc (17 tests)
script         = 2694.31 sec*proc (17 tests)

Total Test time (real) = 526.96 sec

workdir: /scratch3/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/522

@ShunLiu-NOAA ShunLiu-NOAA merged commit 33813fd into NOAA-EMC:develop Jan 14, 2026
1 check passed
@SamuelDegelia-NOAA SamuelDegelia-NOAA deleted the feature/dbz_yaml_updates branch January 21, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants