"NGWPC NWM PI-3 Formulation Selection Delivery 2026-02-25#44
Open
cmaynard-ngwpc wants to merge 70 commits intoNOAA-OWP:masterfrom
Open
"NGWPC NWM PI-3 Formulation Selection Delivery 2026-02-25#44cmaynard-ngwpc wants to merge 70 commits intoNOAA-OWP:masterfrom
cmaynard-ngwpc wants to merge 70 commits intoNOAA-OWP:masterfrom
Conversation
NGWPC-4425 add logging to LASAM module See merge request NGWPC/nwm-ngen/lgar-c!1
missed to commit Logger.cpp/hpp See merge request NGWPC/nwm-ngen/lgar-c!2
converted printfs, which on the first cut went under radar, into DEBUG level logs and some logging optimizations See merge request NGWPC/nwm-ngen/lgar-c!3
Add version.txt file See merge request NGWPC/nwm-ngen/lgar-c!4
Add version.txt file to release-candidate branch See merge request NGWPC/nwm-ngen/lgar-c!5
Release candidate Branch Merge to main for Release 1.0.0 See merge request NGWPC/nwm-ngen/lgar-c!6
Release 0.0.0 udpate version file See merge request NGWPC/nwm-ngen/lgar-c!7
Release 1.0.0 Merge to development See merge request NGWPC/nwm-ngen/lgar-c!8
…nto DEBUG level logs" This reverts commit 8d90ca2.
NGWPC-4425 add logging to LASAM module See merge request NGWPC/nwm-ngen/lgar-c!1
Revert "converted printfs, which on the first cut went under radar, into DEBUG level logs" See merge request NGWPC/nwm-ngen/lgar-c!9
Added RTX licensing verbiage See merge request NGWPC/nwm-ngen/lgar-c!10
Fix for NGWPC-5545 plus Merge branch 'NGWPC-4425' into 'development' See merge request NGWPC/nwm-ngen/lgar-c!11
Merge development into release-candidate for release rc-1.1.0 See merge request NGWPC/nwm-ngen/lgar-c!12
Merge update_version_file_rc-1.1.0 into release-candidate for release rc-1.1.0 See merge request NGWPC/nwm-ngen/lgar-c!13
Merge release-candidate into development for release rc-1.1.0 See merge request NGWPC/nwm-ngen/lgar-c!14
Merge release-candidate into master for release 1.1.0 See merge request NGWPC/nwm-ngen/lgar-c!15
Merge update_version_file_1.2.0 into master for release 1.2.0 See merge request NGWPC/nwm-ngen/lgar-c!23
Merge master into development for release 1.2.0 See merge request NGWPC/nwm-ngen/lgar-c!24
Add CMake artifact generation directory to gitigmore See merge request NGWPC/nwm-ngen/lgar-c!25
Delete version.txt See merge request NGWPC/nwm-ngen/lgar-c!26
… WARNING to SEVERE
…lopment' Add check for logging enabled, change log levels ERROR to WARNING and WARNING to SEVERE See merge request NGWPC/nwm-ngen/lgar-c!27
Merge development into release-candidate for release 3.1.1.3.0-rc1 See merge request NGWPC/nwm-ngen/lgar-c!28
Merge OWP Github master See merge request NGWPC/nwm-ngen/lgar-c!30
Add serialization methods for BmiLGAR See merge request NGWPC/nwm-ngen/lgar-c!29
This reverts merge request !29
Revert "Merge branch 'idt/bmi-serialization' into 'development'" See merge request NGWPC/nwm-ngen/lgar-c!31
State serialization for BMI See merge request NGWPC/nwm-ngen/lgar-c!32
Convert assert calls to error logs (NGWPC-7474)
Merge release-candidate into development for release 3.1.1.3.0-rc2
Adapt serialization to revised protocol
Add NWM Ponded Depth (NGWPC-9175)
Merge development into ngwpc-candidate for release 3.1.2.1.0-rc1
Merge ngwpc-candidate into ngwpc-release for release 3.1.2.1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for NWM ponded depth output, including new output variables and supporting infrastructure. It also exposes logging configuration via a new accessor and includes a minor spelling correction.
Additions
NWM_PONDED_DEPTHoutput field.GetLogLevelaccessor in the source to allow retrieval of the current logging level.Changes
Removals