PR: [1pt] More efficient file read in FLASH FIM#1745
Closed
groutr wants to merge 3 commits intoNOAA-OWP:devfrom
Closed
PR: [1pt] More efficient file read in FLASH FIM#1745groutr wants to merge 3 commits intoNOAA-OWP:devfrom
groutr wants to merge 3 commits intoNOAA-OWP:devfrom
Conversation
groutr
changed the title
CarsonPruitt-NOAA
changed the title
Author
|
I realized the range processing loop doesn't depend on the file being open, so we can just read the band then close the file. |
RileyMcDermott-NOAA
added a commit
that referenced
this pull request
Apr 6, 2026
30 tasks
Contributor
|
Rolled into PR 1803: Optimize FLASH FIM Workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructured the reading of the grib file to make it more efficient. It reads the file once outside the loop instead of each loop iteration.
ping @CarsonPruitt-NOAA