Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Cycling ratio need to be applied inside VRFOU_CalcCompH
because the demand is roughly Q_evap_req = TU_load + Pipe_Q - Ncomp (multiplied by an adjustment factor C_cap_operation). Ncomp is an input-ouptut variable of the function. Previously Cycling ratio is multiplied outside of VRFOU_CalcCompH after the function has computed Ncomp. However, this will lead to very small cycling ratio non-compatible with the demand as the demand is underestimated because of the Ncomp (in reality it should not be this large, it should be Ncomp * CyclingRatio). This doesn't matter on the cooling side as Ncomp is not involved in the demand calculation there.
- Loading branch information
0dfe6b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixVRFhighCOP (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (2915 of 2916 tests passed, 0 test warnings)
Failures:\n
EnergyPlusFixture Test Summary
0dfe6b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixVRFhighCOP (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-RelWithDebInfo: Tests Failed (0 of 0 tests passed, 0 test warnings)
0dfe6b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixVRFhighCOP (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-RelWithDebInfo: Tests Failed (0 of 0 tests passed, 0 test warnings)
0dfe6b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixVRFhighCOP (Unknown) - Win64-Windows-10-VisualStudio-16: OK (2893 of 2894 tests passed, 0 test warnings)
Failures:\n
EnergyPlusFixture Test Summary