Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
revert abs(Q_coil), reduce h_IU_cond_in label230, fix Q_evap_req neg
per Mike's comment, #10649 (comment), Q_coil should not be negative, remove the abs(Q_coil) fix Q_evap_req will be negative if Q_cond_req < CompEvaporatingPWRSpd(CounterCompSpdTemp). This leads to negative compressor speed. Temtatively fix it like this. According to comment here #10649 (comment), The h_comp_out and h_comp_out_new could keep getting farther and farther from each other if h_cond_IU_in can only increase in the iteration. Addressing this by adding a direction where h_cond_IU can decrease as well.
- Loading branch information
cabd9e6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixVRFnegativeFanPower (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3344 of 3698 tests passed, 8 test warnings)
Messages:\n
Failures:\n
regression Test Summary
cabd9e6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixVRFnegativeFanPower (Unknown) - Win64-Windows-10-VisualStudio-16: OK (2864 of 2864 tests passed, 0 test warnings)
cabd9e6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixVRFnegativeFanPower (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (796 of 796 tests passed, 0 test warnings)
cabd9e6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixVRFnegativeFanPower (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (2071 of 2071 tests passed, 0 test warnings)