Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed transition #10713

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Fix failed transition #10713

merged 2 commits into from
Sep 10, 2024

Conversation

lymereJ
Copy link
Collaborator

@lymereJ lymereJ commented Sep 3, 2024

Pull request overview

With the (very) small changes from that branch, the defect file can be transitioned.

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@lymereJ lymereJ added the Defect Includes code to repair a defect in EnergyPlus label Sep 3, 2024
@lymereJ lymereJ self-assigned this Sep 3, 2024
@lymereJ lymereJ marked this pull request as draft September 3, 2024 23:49
@lymereJ lymereJ added this to the EnergyPlus 24.2 milestone Sep 4, 2024
@lymereJ lymereJ marked this pull request as ready for review September 4, 2024 03:00
OldFanVO(NumOldFanVO)%endUseSubCat = TRIM(IDFRecords(Num)%Alphas(6))
IF (lEN(IDFRecords(Num)%Alphas) .eq. 6) THEN
OldFanVO(NumOldFanVO)%endUseSubCat = TRIM(IDFRecords(Num)%Alphas(6))
ENDIF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjwitte I was going to write that I was concerned about using the LEN of Alphas here. But this is directly grabbing it from the IDFRecords array, so I guess it's going to be accurate. This is fine with me if you see it working for you @lymereJ and @mjwitte doesn't see any red flags.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a similar concern, but I think it's ok. I suppose at some point before release, we should run the full set of testfiles from 24.1 through transition and make sure they run without errors.

@Myoldmopar
Copy link
Member

I won't hold this up just because it is written as lEN instead of LEN. :) This can go in. Thanks @lymereJ . And yes, @mjwitte, it would be reasonable to transition up all the 24.1 files...

@Myoldmopar Myoldmopar merged commit 57c067a into develop Sep 10, 2024
12 checks passed
@Myoldmopar Myoldmopar deleted the fix_transition branch September 10, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition to 24.2 fails
3 participants