Yet Another Silly Blind-Related Bug #10717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirroth
added
Defect
Myoldmopar
approved these changes
Sep 5, 2024
| @@ -6458,7 +6458,7 @@ namespace Window { | |||
| RhoBlDiffBack = InterpSlatAng(SlatAng, VarSlats, blind.SolBackDiffDiffRefl); | |||
| RhoBlDiffBackVis = InterpSlatAng(SlatAng, VarSlats, blind.VisBackDiffDiffRefl); | |||
| RhoBlBack = InterpProfSlatAng(0.0, SlatAng, VarSlats, blind.SolBackBeamDiffRefl); | |||
| RhoBlBackVis = InterpProfSlatAng(0.0, SlatAng, VarSlats, blind.SolBackBeamDiffRefl); | |||
| RhoBlBackVis = InterpProfSlatAng(0.0, SlatAng, VarSlats, blind.VisBackBeamDiffRefl); | |||
There was a problem hiding this comment.
Vis :: Vis, looks like a good match to me now.
|
The Windows build failure is because it couldn't delete a temporary file or something on the Decent machine. Obviously unrelated to this one line fix. I'll let the Mac GHA build finish in about 5 minutes and verify any diffs and results. Then this can drop right in. |
|
|
All happy, tiny little diffs. Good to go, thanks @amirroth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another silly bug with a one line fix discovered during a refactor. Like the other one, I may have introduced this one myself in a prior PR.
The diffs are expected, the bug was in reporting window properties (solar reflectance was used where visible reflectance should have been).