Add Space Component Loads Report and Fix Zone Component Loads when Enclosures Differ from Zones #10730

mjwitte · 2024-09-12T03:10:07Z

Pull request overview

Adds Space Component Loads Report. This report will be produced when the Zone Component Loads Report is requested and "Do Space Heat Balance for Sizing" is active.
Fixes Zone Component Loads Report may be incorrect when Zones and Enclosures are not the same #10784
Replaced 33 Array3D with nested vectors of structs in OutputReportsTabular.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

…oads

github-actions · 2024-09-18T22:04:51Z

⚠️ Regressions detected on macos-14 for commit `aaf7933`

Regression Summary

ESO Big Diffs: 1

…oads

github-actions · 2024-09-19T22:27:20Z

⚠️ Regressions detected on macos-14 for commit `5631bbf`

Regression Summary

ESO Big Diffs: 1

…oads

github-actions · 2024-09-20T23:15:50Z

⚠️ Regressions detected on macos-14 for commit `ce39eda`

Regression Summary

Table Big Diffs: 2
ESO Big Diffs: 1

rraustad · 2024-09-21T02:00:54Z

src/EnergyPlus/InternalHeatGains.cc

+                    auto &spCLDayTS = state.dataOutRptTab->spCompLoads[iSpace - 1].day[state.dataSize->CurOverallSimDay - 1].ts[TimeStepInDay - 1];
+                    gatherCompLoadIntGain2(state, spCLDayTS, state.dataHeatBal->space(iSpace).zoneNum, iSpace);
+                }
+            }


I recall something about if space heat balance is active, then the zone HB results are overwritten with the sum of the spaces. If that's true then why bother processing the zones at all (line 9511) if those results are overwritten by 9516? Is line 9516 iSpace = 1 to NumOfZones, or 1 to numSpaces?

If (state.dataHeatBal->doSpaceHeatBalanceSizing) { gather spaces, 9516 to 9519 } else { gather zones, 9511 to 9514 }

That's possible. Baby steps at this point. Just trying to find all of the places that apply so that the space results are really just for the space.

github-actions · 2024-09-23T18:28:23Z

⚠️ Regressions detected on macos-14 for commit `912635e`

Regression Summary

Table Big Diffs: 2

…oads

github-actions · 2024-10-03T22:29:09Z

⚠️ Regressions detected on macos-14 for commit `2618270`

Regression Summary

EIO: 2
Table Big Diffs: 5

github-actions · 2024-10-04T21:13:15Z

⚠️ Regressions detected on macos-14 for commit `b91e671`

Regression Summary

Table Big Diffs: 5

github-actions · 2024-10-11T16:06:09Z

⚠️ Regressions detected on macos-14 for commit `7366aec`

Regression Summary

Table Big Diffs: 5

mjwitte

Refactoring code walkthru . . .

mjwitte · 2024-10-11T17:45:44Z

src/EnergyPlus/CurveManager.cc

@@ -53,7 +53,6 @@

 // ObjexxFCL Headers
 #include <ObjexxFCL/Array.functions.hh>
-#include <ObjexxFCL/Array3D.hh>


Removed several stray includes that were no longer being used.

mjwitte · 2024-10-11T17:47:31Z

src/EnergyPlus/OutputReportTabular.cc

-    Array1D<Real64> peopleDelaySeqHeat;
-    Array1D<Real64> peopleDelaySeqCool;


These arrays are temporary and used one at a time, collapsed into a single set to use for both heat and cool.

mjwitte · 2024-10-11T17:51:32Z

src/EnergyPlus/OutputReportTabular.hh

+    struct compLoadsSurface
+    {
+        Real64 loadConvectedNormal = 0.0;
+        Real64 loadConvectedWithPulse = 0.0;
+        Real64 netSurfRadSeq = 0.0;
+        Real64 ITABSFseq = 0.0;     // used for determining the radiant fraction on each surface
+        Real64 TMULTseq = 0.0;      // used for determining the radiant fraction on each surface
+        Real64 lightSWRadSeq = 0.0; // short wave visible radiation
+        Real64 feneSolarRadSeq = 0.0;
+    };
+
+    struct compLoadsTimeStepSurfaces
+    {
+        std::vector<compLoadsSurface> surf;
+    };
+
+    struct componentLoadsSurf
+    {
+        std::vector<compLoadsTimeStepSurfaces> ts;
+    };


New sets of nested vectors to replace a bunch of loose Array3D. This is for surfaces, similar ones for zone/spaces, and enclosures.

mjwitte · 2024-10-11T17:52:59Z

src/EnergyPlus/OutputReportTabular.hh

-    Array3D<Real64> loadConvectedNormal;
-    Array3D<Real64> loadConvectedWithPulse;
-    Array3D<Real64> netSurfRadSeq;


Replaced these and many other Array3D with nested std::vector.

mjwitte · 2024-10-11T17:54:09Z

src/EnergyPlus/OutputReportTabular.hh

+    std::vector<OutputReportTabular::componentLoadsSurf> surfCompLoads; // Surface component loads by day, timestep, then surface
+    std::vector<OutputReportTabular::componentLoadsSpZn> znCompLoads;   // Zone component loads by day, timestep, then zone
+    std::vector<OutputReportTabular::componentLoadsSpZn> spCompLoads;   // Space component loads by day, timestep, then space
+    std::vector<OutputReportTabular::componentLoadsEncl> enclCompLoads; // Enclosure component loads by day, timestep, then enclsoure


New component loads vectors for surface, zone, space, and enclosure.

mjwitte · 2024-10-11T17:54:49Z

src/EnergyPlus/OutputReportTabular.hh

-    int ZoneNumCLCDC = 0;
-    int SurfNumCLCDC = 0;
-    int TimeStepCLCDC = 0;
-    int TimeOfPulseCLCDC = 0;
-    int CoolDesSelectedCLCDC = 0; // design day selected for cooling
-    int HeatDesSelectedCLCDC = 0; // design day selected for heating
-    int iSurfGCLS = 0;
-    int ZoneNumGCLS = 0;
-    int TimeStepInDayGCLS = 0;
-    int iZoneGCLH = 0;
-    int TimeStepInDayGCLH = 0;
-    Array3D_bool adjFenDone;


Moved out of state.

mjwitte

Walkthru for fix #10784 . . .

mjwitte · 2024-10-11T18:08:32Z

src/EnergyPlus/InternalHeatGains.cc

@@ -9229,6 +9303,32 @@ namespace InternalHeatGains {
        return SumRadiationGainRate;
    }

+    Real64 SumEnclosureInternalRadiationGainsByTypes(


New function to sum radiant gains by enclosure.

mjwitte · 2024-10-11T18:10:05Z

src/EnergyPlus/InternalHeatGains.cc

+            for (int iEncl = 1; iEncl <= state.dataViewFactor->NumOfRadiantEnclosures; ++iEncl) {
+                auto &enclCLDayTS = state.dataOutRptTab->enclCompLoads[state.dataSize->CurOverallSimDay - 1].ts[TimeStepInDay - 1].encl[iEncl - 1];
+                enclCLDayTS.peopleRadSeq = SumEnclosureInternalRadiationGainsByTypes(state, iEncl, IntGainTypesPeople);
+                enclCLDayTS.lightLWRadSeq = SumEnclosureInternalRadiationGainsByTypes(state, iEncl, IntGainTypesLight);
+                enclCLDayTS.equipRadSeq = SumEnclosureInternalRadiationGainsByTypes(state, iEncl, IntGainTypesEquip);
+                enclCLDayTS.hvacLossRadSeq = SumEnclosureInternalRadiationGainsByTypes(state, iEncl, IntGainTypesHvacLoss);
+                enclCLDayTS.powerGenRadSeq = SumEnclosureInternalRadiationGainsByTypes(state, iEncl, IntGainTypesPowerGen);
+            }


Save enclosure gain sequences by type for use later in component load calcs.

mjwitte · 2024-10-11T18:13:46Z

src/EnergyPlus/OutputReportTabular.cc

-                        lightLWConvFromSurf += ort->lightLWRadSeq(desDaySelected, sourceStep, zoneIndex) * thisQRadThermInAbsMult;
+                        auto &compLoadTS = szCLDay.ts[sourceStep - 1].spacezone[szNumMinus1];
+                        auto const &surfCLDayTS = surfCLDay.ts[sourceStep - 1].surf[jSurf - 1];
+                        auto const &enclCLDayTS = enclCLDay.ts[sourceStep - 1].encl[radEnclosureNum - 1];
+                        Real64 thisQRadThermInAbsMult =
+                            surfCLDayTS.TMULTseq * surfCLDayTS.ITABSFseq * state.dataSurface->Surface(jSurf).Area * decayCurve(mStepBack, jSurf);
+                        peopleConvFromSurf += enclCLDayTS.peopleRadSeq * thisQRadThermInAbsMult;


Use enclosure gain sequences now. Previously, zone gains were used which could be high or low depending on how the zones/spaces/enclosures align.

…oads

mjwitte

Space component loads walkthru . . .

mjwitte · 2024-10-11T18:18:03Z

src/EnergyPlus/HVACManager.cc

+    for (int zoneNum = 1; zoneNum <= state.dataGlobal->NumOfZones; ++zoneNum) { // Start of zone loads report variable update loop ...
+        auto &zone = state.dataHeatBal->Zone(zoneNum);
+        auto &znAirRpt = state.dataHeatBal->ZnAirRpt(zoneNum);
+        auto &znEquipConfig = state.dataZoneEquip->ZoneEquipConfig(zoneNum);
+        reportAirHeatBal1(state, znAirRpt, znEquipConfig, zoneNum);
+    }
+    if (state.dataHeatBal->doSpaceHeatBalance) {
+        for (int spaceNum = 1; spaceNum <= state.dataGlobal->numSpaces; ++spaceNum) {
+            auto &spAirRpt = state.dataHeatBal->spaceAirRpt(spaceNum);
+            auto &spEquipConfig = state.dataZoneEquip->spaceEquipConfig(spaceNum);
+            int zoneNum = state.dataHeatBal->space(spaceNum).zoneNum;
+            reportAirHeatBal1(state, spAirRpt, spEquipConfig, zoneNum, spaceNum);


Break up ReportAirHeatBalance into smaller functions that can be re-used for zones and spaces.

mjwitte · 2024-10-11T18:20:57Z

src/EnergyPlus/HVACManager.hh

-    Array1D<Real64> MixSenLoad; // Mixing sensible loss or gain
-    Array1D<Real64> MixLatLoad; // Mixing latent loss or gain


Moved to DataHeatBalance::AirReportVars.

mjwitte · 2024-10-11T18:24:08Z

src/EnergyPlus/HeatBalanceAirManager.cc

@@ -286,7 +286,7 @@ void GetSimpleAirModelInputs(EnergyPlusData &state, bool &ErrorsFound) // IF err

    // Following used for reporting
    state.dataHeatBal->ZnAirRpt.allocate(state.dataGlobal->NumOfZones);
-    if (state.dataHeatBal->doSpaceHeatBalanceSimulation) {
+    if (state.dataHeatBal->doSpaceHeatBalance) {


Hmm, this is wrong, should be doSpaceHeatBalanceSimulation || doSpaceHeatBalanceSizing. It might be ok, but not safe if sizing is false and simulation is true. Will fix.

mjwitte · 2024-10-11T18:46:52Z

src/EnergyPlus/OutputReportTabular.cc

+    for (int iZoneGCLH = 1; iZoneGCLH <= state.dataGlobal->NumOfZones; ++iZoneGCLH) {
+        auto &znCompLoadDayTSZone = znCompLoadDayTS.spacezone[iZoneGCLH - 1];
+        auto &zoneAirRpt = state.dataHeatBal->ZnAirRpt(iZoneGCLH);
+        gatherSpaceZoneCompLoadsHVAC(znCompLoadDayTSZone, zoneAirRpt, state.dataHVACGlobal->TimeStepSysSec);


Another breakup into smaller functions.

mjwitte · 2024-10-11T18:48:42Z

src/EnergyPlus/OutputReportTabular.cc

+                    int zoneNum = state.dataHeatBal->space(iSpace).zoneNum;
+                    if (!state.dataZoneEquip->ZoneEquipConfig(zoneNum).IsControlled) continue;
+                    if (allocated(state.dataSize->CalcFinalSpaceSizing)) {
+                        computeSpaceZoneCompLoads(state,


This pattern repeats several times, called for either space of zone.

github-actions · 2024-10-11T19:51:31Z

⚠️ Regressions detected on macos-14 for commit `85bf54b`

Regression Summary

Table Big Diffs: 5

mjwitte added 6 commits September 10, 2024 15:16

Space IV.6 - component loads 1

a44e81e

Merge remote-tracking branch 'remotes/origin/develop' into spaceCompL…

f46b541

…oads

Space IV.6 - component loads 2

1151757

Space IV.6 - component loads 3 - consolidate seq arrays

d7ca028

Space IV.6 - component loads 4

6491fc6

Space IV.6 - component loads 4 fix

d9f4b5c

mjwitte added NewFeature Includes code to add a new feature to EnergyPlus NotIDDChange Code does not impact IDD (can be merged after IO freeze) labels Sep 12, 2024

mjwitte added this to the EnergyPlus 24.2 milestone Sep 12, 2024

Merge remote-tracking branch 'remotes/origin/develop' into spaceCompL…

fa3a81a

…oads

mjwitte modified the milestones: EnergyPlus 24.2, EnergyPlus 25.1 IO Freeze Sep 12, 2024

mjwitte added 3 commits September 18, 2024 13:29

Merge remote-tracking branch 'remotes/origin/develop' into spaceCompL…

17cd602

…oads

Space IV.6 - component loads ReportAirHeatBalance

c12a40b

Space IV.6 - component loads state reduction

75ccde6

mjwitte added 2 commits September 19, 2024 11:19

Merge remote-tracking branch 'remotes/origin/develop' into spaceCompL…

0957051

…oads

Space IV.6 - simple airflow and AirRpt cleanup

ac222b0

mjwitte added 2 commits September 20, 2024 13:37

Merge remote-tracking branch 'remotes/origin/develop' into spaceCompL…

9881656

…oads

Space IV.6 - unwind some 3D comp loads arrays

00f67f0

rraustad reviewed Sep 21, 2024

View reviewed changes

mjwitte added 2 commits September 23, 2024 10:54

Space IV.6 - unwind some 3D comp loads arrays cleanup

a9a35c9

Space IV.6 - fix ZoneRefrigerationDoorMixing diffs

634d933

mjwitte added 4 commits September 23, 2024 17:01

Merge remote-tracking branch 'remotes/origin/develop' into spaceCompL…

5aa85e3

…oads

Space IV.6 - unwind 3D comp loads arrays fix fenestration

9d8ee71

Clear debug code

77e436d

Space IV.6 - component loads gather HVAC

075de46

mjwitte added 8 commits September 24, 2024 13:58

Delete stray Array3D includes

70e9cc4

Space IV.6 - unwind 3D comp loads arrays for surfaces

69432ed

Revert errant VS reformat

cf45780

Space IV.6 - component loads rename reorder

227c141

Space IV.6 - fix delayed int gains for space and zone

22c969c

Merge remote-tracking branch 'remotes/origin/develop' into spaceCompL…

d77ac57

…oads

Merge remote-tracking branch 'remotes/origin/develop' into spaceCompL…

2f7cb4f

…oads

Space IV.6 - improve delayed surf gains for space

2af52b9

mjwitte added 3 commits October 4, 2024 11:01

Move a few InternalHeatGains variables out of state

5c82432

Move a few HeatBalanceSurfaceManager variables out of state

c6f4c5b

Space IV.6 - revert separate space and zone decay curves

6f091eb

Space IV.6 - fix delayed surf gains for space

023142d

mjwitte marked this pull request as ready for review October 11, 2024 17:21

mjwitte added Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring Defect Includes code to repair a defect in EnergyPlus labels Oct 11, 2024

mjwitte changed the title ~~Space Component Loads Report~~ Add Space Component Loads Report and Fix Zone Component Loads when Enclosures Differ from Zones Oct 11, 2024

mjwitte commented Oct 11, 2024

View reviewed changes

mjwitte added 3 commits October 11, 2024 13:23

Merge remote-tracking branch 'remotes/origin/develop' into spaceCompL…

24c7a50

…oads

Merge remote-tracking branch 'remotes/origin/develop' into spaceCompL…

ac27ef4

…oads

Space IV.6 - fix test for spaceAirRpt.allocate

21c20f5

mjwitte commented Oct 11, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Space Component Loads Report and Fix Zone Component Loads when Enclosures Differ from Zones #10730

Add Space Component Loads Report and Fix Zone Component Loads when Enclosures Differ from Zones #10730

mjwitte commented Sep 12, 2024 •

edited

Loading

github-actions bot commented Sep 18, 2024

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 20, 2024

rraustad Sep 21, 2024 •

edited

Loading

mjwitte Sep 23, 2024

github-actions bot commented Sep 23, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 4, 2024

github-actions bot commented Oct 11, 2024

mjwitte left a comment

mjwitte Oct 11, 2024 •

edited

Loading

mjwitte Oct 11, 2024

mjwitte Oct 11, 2024

mjwitte Oct 11, 2024

mjwitte Oct 11, 2024

mjwitte Oct 11, 2024

mjwitte left a comment

mjwitte Oct 11, 2024

mjwitte Oct 11, 2024

mjwitte Oct 11, 2024

mjwitte left a comment

mjwitte Oct 11, 2024

mjwitte Oct 11, 2024

mjwitte Oct 11, 2024

mjwitte Oct 11, 2024

mjwitte Oct 11, 2024

github-actions bot commented Oct 11, 2024

		Array1D<Real64> peopleDelaySeqHeat;
		Array1D<Real64> peopleDelaySeqCool;

		Array1D<Real64> MixSenLoad; // Mixing sensible loss or gain
		Array1D<Real64> MixLatLoad; // Mixing latent loss or gain

Add Space Component Loads Report and Fix Zone Component Loads when Enclosures Differ from Zones #10730

Are you sure you want to change the base?

Add Space Component Loads Report and Fix Zone Component Loads when Enclosures Differ from Zones #10730

Conversation

mjwitte commented Sep 12, 2024 • edited Loading

Pull request overview

Pull Request Author

Reviewer

github-actions bot commented Sep 18, 2024

⚠️ Regressions detected on macos-14 for commit aaf7933

github-actions bot commented Sep 19, 2024

⚠️ Regressions detected on macos-14 for commit 5631bbf

github-actions bot commented Sep 20, 2024

⚠️ Regressions detected on macos-14 for commit ce39eda

rraustad Sep 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 23, 2024

⚠️ Regressions detected on macos-14 for commit 912635e

github-actions bot commented Oct 3, 2024

⚠️ Regressions detected on macos-14 for commit 2618270

github-actions bot commented Oct 4, 2024

⚠️ Regressions detected on macos-14 for commit b91e671

github-actions bot commented Oct 11, 2024

⚠️ Regressions detected on macos-14 for commit 7366aec

mjwitte left a comment

Choose a reason for hiding this comment

mjwitte Oct 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjwitte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjwitte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Oct 11, 2024

⚠️ Regressions detected on macos-14 for commit 85bf54b

mjwitte commented Sep 12, 2024 •

edited

Loading

⚠️ Regressions detected on macos-14 for commit `aaf7933`

⚠️ Regressions detected on macos-14 for commit `5631bbf`

⚠️ Regressions detected on macos-14 for commit `ce39eda`

rraustad Sep 21, 2024 •

edited

Loading

⚠️ Regressions detected on macos-14 for commit `912635e`

⚠️ Regressions detected on macos-14 for commit `2618270`

⚠️ Regressions detected on macos-14 for commit `b91e671`

⚠️ Regressions detected on macos-14 for commit `7366aec`

mjwitte Oct 11, 2024 •

edited

Loading

⚠️ Regressions detected on macos-14 for commit `85bf54b`