Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CppCheck OutputReportTabular #10740

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

CppCheck OutputReportTabular #10740

wants to merge 21 commits into from

Conversation

rraustad
Copy link
Contributor

Pull request overview

  • Fixes programming style
  • Use CppCheck as guide

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@rraustad rraustad added the DoNotPublish Includes changes that shouldn't be reported in the changelog label Sep 15, 2024
rraustad
rraustad commented Sep 15, 2024
View reviewed changes
src/EnergyPlus/OutsideEnergySources.cc
@@ -175,7 +175,7 @@ void GetOutsideEnergySourcesInput(EnergyPlusData &state)
EnergyType = DataPlant::PlantEquipmentType::PurchHotWater;
heatWaterIndex++;
thisIndex = heatWaterIndex;
} else if (EnergySourceNum > NumDistrictUnitsHeatWater && EnergySourceNum <= NumDistrictUnitsHeatWater + NumDistrictUnitsCool) {
} else if (EnergySourceNum <= NumDistrictUnitsHeatWater + NumDistrictUnitsCool) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[src/EnergyPlus/OutsideEnergySources.cc:178]:(style),[knownConditionTrueFalse],Condition 'EnergySourceNum>NumDistrictUnitsHeatWater' is always true

rraustad
rraustad commented Sep 15, 2024
View reviewed changes
src/EnergyPlus/PhaseChangeModeling/HysteresisModel.cc
@@ -95,12 +95,12 @@ namespace Material {
Tau2 = this->deltaTempMeltingHigh;
if (updatedTempTDT < TempLowPCM) {
phaseChangeState = Phase::Crystallized;
} else if (updatedTempTDT >= TempLowPCM && updatedTempTDT <= TempHighPCM) {
} else if (updatedTempTDT <= TempHighPCM) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[src/EnergyPlus/PhaseChangeModeling/HysteresisModel.cc:98]:(style),[knownConditionTrueFalse],Condition 'updatedTempTDT>=TempLowPCM' is always true

rraustad
rraustad commented Sep 15, 2024
View reviewed changes
src/EnergyPlus/PhotovoltaicThermalCollectors.cc
0.00010184 * (t_film + 273.15) - 0.00039333; // Dumas, A., and Trancossi, M., SAE Technical Papers, 2009
density_air = 101.3 / (0.287 * (t_film + 273.15)); // Ideal gas law
diffusivity_air = k_air / (cp_amb * density_air); // definition
kin_viscosity_air = mu_air / density_air; // definition
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[src/EnergyPlus/PhotovoltaicThermalCollectors.cc:1530]:(style),[redundantAssignment],Variable 'prandtl_air' is reassigned a value before the old one has been used.

rraustad
rraustad commented Sep 16, 2024
View reviewed changes
src/EnergyPlus/Photovoltaics.cc
Real64 const II, // Autodesk Aliased to XX in some calls
Real64 const VV, // Autodesk Aliased to XX in some calls
Real64 const &II, // Autodesk Aliased to XX in some calls
Real64 const &VV, // Autodesk Aliased to XX in some calls
Copy link
Contributor Author

@rraustad rraustad Sep 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugger showed an uninitialized argument in the call to the NEWTON function for argument II. Changing the argument declarations back to what it was previously corrected the example file failures for GeneratorswithPV and ShopWithBIPVT.

@rraustad rraustad added this to the EnergyPlus 25.1 milestone Sep 25, 2024
@nrel-bot-2c
Copy link

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DoNotPublish Includes changes that shouldn't be reported in the changelog
Projects
None yet
Milestone
EnergyPlus 25.1
Development

Successfully merging this pull request may close these issues.
4 participants
@rraustad @nrel-bot-2c @nrel-bot @nrel-bot-2