Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimum and default for the Condenser Minimum Flow Fraction field #10779

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add minimum and default for the Condenser Minimum Flow Fraction field #10779

wants to merge 3 commits into from

Conversation

lymereJ
Copy link
Collaborator

@lymereJ lymereJ commented Oct 2, 2024

Pull request overview

  • Address this review comment.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@lymereJ lymereJ added the Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring label Oct 2, 2024
@lymereJ lymereJ mentioned this pull request Oct 2, 2024
Merged
16 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

⚠️ Regressions detected on macos-14 for commit e84a255

Regression Summary
  • Table Small Diffs: 27
  • Table Big Diffs: 7

jmarrec
jmarrec approved these changes Oct 3, 2024
View reviewed changes
idd/Energy+.idd.in Outdated
Comment on lines 73679 to 73680
\minimum> 0.0
\default 0.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lymereJ

Just checking: is 0.0 not a valid value?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And does > 1 make sense here? Otherwise \maximum 1 would be good?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minimum was copy/paste typo, good catch. I'll add the maximum.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

⚠️ Regressions detected on macos-14 for commit 3779911

Regression Summary
  • Table Small Diffs: 27
  • Table Big Diffs: 7

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

⚠️ Regressions detected on macos-14 for commit b2780f8

Regression Summary
  • Table Small Diffs: 27
  • Table Big Diffs: 7

@nrel-bot-2
Copy link

@lymereJ @Myoldmopar it has been 28 days since this pull request was last updated.

@Myoldmopar
Copy link
Member

This looks quite reasonable. Thanks @lymereJ, merging this shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarrec jmarrec jmarrec approved these changes

Assignees
No one assigned
Labels
Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lymereJ @nrel-bot-2 @Myoldmopar @jmarrec @nrel-bot @nrel-bot-2b @nrel-bot-2c