Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DOAS system sizing and add reporting #10783

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix DOAS system sizing and add reporting #10783

wants to merge 2 commits into from

Conversation

EnergyArchmage
Copy link
Contributor

Pull request overview

Code fixes for volume vs mass flow rate mix up. add reporting of sizing results

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

⚠️ Regressions detected on macos-14 for commit 43e839f

Regression Summary
  • Audit: 1
  • EIO: 1
  • ESO Big Diffs: 1
  • MTR Big Diffs: 1
  • Table Big Diffs: 1

@mjwitte
Copy link
Contributor

mjwitte commented Oct 22, 2024

@EnergyArchmage Is this ready for review?

@rraustad
Copy link
Contributor

@mjwitte this is ready for review. I have looked over it and it is the same as used in the other engine.

@EnergyArchmage
Copy link
Contributor Author

This good to go, but may have a follow up to have both a max and min design size. Coils are getting oversized using only max oa flow.

@mjwitte
Copy link
Contributor

mjwitte commented Oct 22, 2024

There's a failing unit test, AirLoopHVACDOAS_TestFanHeatAddeToCoolingCoilSize.

@EnergyArchmage EnergyArchmage added the Defect Includes code to repair a defect in EnergyPlus label Oct 23, 2024
@github-actions GitHub Actions
Copy link

⚠️ Regressions detected on macos-14 for commit a5e355c

Regression Summary
  • Audit: 1
  • EIO: 1
  • ESO Big Diffs: 1
  • MTR Big Diffs: 1
  • Table Big Diffs: 1

mjwitte
mjwitte reviewed Oct 24, 2024
View reviewed changes
Copy link
Contributor

@mjwitte mjwitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EnergyArchmage Thanks for the unit test fix. This works as advertised. Posted #10802 but that's a separate issue.

src/EnergyPlus/AirLoopHVACDOAS.cc
this->SizingMassFlow = sizingMassFlow;
this->SizingMassFlow = sizingVolumeFlow * state.dataEnvrn->StdRhoAir;

BaseSizer::reportSizerOutput(state, "AirLoopHVAC:DedicatedOutdoorAirSystem", this->Name, "Design Volume Flow Rate [m3/s]", sizingVolumeFlow);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most (all?) other equipment reports sizing as "Design Size Air Flow Rate [m3/s]" or "Design Size Maximum Air Flow Rate". This should probably use similar language. @rraustad ?

Copy link
Contributor

@rraustad rraustad Oct 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually it's "Design Size" or User-Specified" pre-pended on the front end of the field names which are not uniform. But this object doesn't have a field for air flow so it's a sum of this field. I have no preference for this object since it's not autosized or hard-sized but I guess it could match what the air loop reports since that's what gets summed.

AirLoopHVAC,
   N1, \field Design Supply Air Flow Rate

The air loop doesn't follow this naming convention either.

Component Sizing Information, AirLoopHVAC, VAV SYS 1, Design Supply Air Flow Rate [m3/s], 1.08612

Unitary System looks like this:

Component Sizing Information, AirLoopHVAC:UnitarySystem, DX COOLING COIL, Design Size Cooling Supply Air Flow Rate [m3/s], 1.34859
Component Sizing Information, AirLoopHVAC:UnitarySystem, HEATPUMP DX COIL 1, Design Size Heating Supply Air Flow Rate [m3/s], 1.34859

TUs:

Component Sizing Information, AirTerminal:SingleDuct:VAV:Reheat, SPACE1-1 VAV REHEAT, Design Size Maximum Air Flow Rate [m3/s], 0.20149

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it's this field that gets summed:

Controller:OutdoorAir,
  N2 , \field Maximum Outdoor Air Flow Rate

Component Sizing Information, Controller:OutdoorAir, OA CONTROLLER 1, Maximum Outdoor Air Flow Rate [m3/s], 1.08612
Component Sizing Information, Controller:OutdoorAir, OA CONTROLLER 1, Minimum Outdoor Air Flow Rate [m3/s], 0.26412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rraustad rraustad rraustad left review comments

@mjwitte mjwitte mjwitte left review comments

Assignees
No one assigned
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AirLoopHVAC:DedicatedOutdoorAirSystem Sizing Mixing up Mass and Volume Flow Rates, no reporting
7 participants
@EnergyArchmage @mjwitte @rraustad @nrel-bot @nrel-bot-2 @nrel-bot-2b @nrel-bot-2c