Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies #23

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

bayc
Copy link
Collaborator

@bayc bayc commented Oct 24, 2024

Remove unused dependencies

This PR just removes currently unused dependencies. This follows suit of a matching PR for HOPP (NREL/HOPP#383).

Related issue

Fixes #22

Impacted areas of the software

pyproject.toml

Additional supporting information

None.

Test results, if applicable

Need to verify tests are passing.

@bayc bayc added the enhancement New feature or request label Oct 24, 2024
@bayc bayc added this to the v0.1.0 milestone Oct 24, 2024
@bayc bayc self-assigned this Oct 24, 2024
@johnjasa
Copy link
Collaborator

Files changed shows an example modified but not imports? I know this is a draft PR, maybe you have more changes coming!

@bayc bayc linked an issue Oct 24, 2024 that may be closed by this pull request
@bayc bayc force-pushed the feature/remove_unused_dependencies branch from b23d4a7 to e39f5e5 Compare October 25, 2024 16:43
@bayc
Copy link
Collaborator Author

bayc commented Oct 25, 2024

Files changed shows an example modified but not imports? I know this is a draft PR, maybe you have more changes coming!

Thanks for catching that, added the wrong file!

@bayc bayc marked this pull request as ready for review October 25, 2024 16:44
@johnjasa johnjasa merged commit 3ecd63a into NREL:develop Oct 25, 2024
3 checks passed
@bayc bayc deleted the feature/remove_unused_dependencies branch October 25, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

humpday module requires Visual C++ on Windows
2 participants