LCOH Update and Custom Electrolyzer Costs #79

elenya-grant · 2025-01-31T23:20:40Z

Update to LCOH script and added custom electrolyzer cost functionality.

added option for custom electrolyzer cost inputs
updated LCOH script to input electrolyzer lifetime capacity factor as dictionary
added electrolyzer cost tools to summarize electrolyzer physics results appropriately for use in LCOH script
added profast_tools.py file - mostly unused now but will be utilized in future PR to clean up functions in finance.py

PR Checklist

CHANGELOG.md has been updated to describe the changes made in this PR
Documentation
- Docstrings are up-to-date
- Related docs/ files are up-to-date, or added when necessary
- Documentation has been rebuilt successfully
- Examples have been updated
Tests pass (If not, and this is expected, please elaborate in the tests section)
PR description thoroughly describes the new feature, bug fix, etc.

Related issues

Impacted areas of the software

modified: greenheart/tools/eco/finance.py
- run_profast_full_plant_model(): added electrolyzer variable O&M input, changed capacity input to be the electrolyzer rated capacity, changed long term utilization input to be dictionary of electrolyzer capacity factors per year.
modified: greenheart/tools/eco/electrolysis.py
- run_electrolyzer_cost(): updated for custom electrolyzer cost
new: greenheart/simulation/technologies/hydrogen/electrolysis/PEM_costs_custom.py: cost function to calculate electrolyzer capex and fixed o&m for "custom" electrolyzer cost model
new: greenheart/simulation/technologies/hydrogen/electrolysis/pem_cost_tools.py: summarizes electrolyzer physics results for appropriate use in LCOH script
new: greenheart/tools/profast_tools.py: mostly unused for now, tools to automate using and post-processing ProFAST

path/to/file.extension
- method1: What and why something was changed in one sentence or less.

Additional supporting information

Test results, if applicable

jaredthomas68

This is really helpful, thank you!! Main things that are needed are (1) doc strings, (2) all costs need to be discounted in the same way and the same place (capex and opex cost functions), and (3) there are many unused functions that should be saved for a PR that uses them.

greenheart/simulation/technologies/hydrogen/electrolysis/PEM_costs_custom.py

jaredthomas68 · 2025-02-03T23:19:22Z

greenheart/simulation/technologies/hydrogen/electrolysis/pem_cost_tools.py

+import numpy as np
+
+
+def summarize_electrolysis_cost_and_performance(electrolyzer_physics_results, electrolyzer_config):


need doc strings with citation(s)

I've added doc strings!

greenheart/simulation/technologies/hydrogen/electrolysis/pem_cost_tools.py

greenheart/tools/eco/electrolysis.py

jaredthomas68 · 2025-02-03T23:35:52Z

greenheart/tools/eco/finance.py

@@ -1237,6 +1242,19 @@ def run_profast_full_plant_model(
        output_dir = Path(output_dir).resolve()
    gen_inflation = greenheart_config["finance_parameters"]["profast_general_inflation"]

+    if "analysis_start_year" not in greenheart_config["finance_parameters"]:
+        analysis_start_year = greenheart_config["project_parameters"]["atb_year"] + 2
+    if "installation_period_months" not in greenheart_config["finance_parameters"]:


This will fail if wind is not in the simulation. I think we should just raise errors on both of there with instructions to set the parameters.

I moved analysis_start_year to be added to config.greenheart_config["finance_parameters"] in the __attrs_post_init__ method of GreenHeartSimulationConfig.

I moved installation_period_months to be set in setup_greenheart_simulation() depending on whether wind_cost_results has that as a variable or not.

greenheart/tools/profast_tools.py

jaredthomas68 · 2025-02-04T00:14:09Z

greenheart/tools/profast_tools.py

+    return pf_config
+
+
+def create_and_populate_profast(pf_config):


This could be useful, but is not used. Let's hold off on this until we are ready to use it if it is not too hard.

jaredthomas68 · 2025-02-04T00:15:21Z

greenheart/tools/profast_tools.py

+    return pf
+
+
+def run_profast(pf):


Again, not used so should probably be in a different PR

jaredthomas68 · 2025-02-04T00:16:24Z

greenheart/tools/profast_tools.py

+    return sol, summary, price_breakdown
+
+
+def make_price_breakdown(price_breakdown, pf_config):


Could be useful now. Let's keep this even if we are not using it yet.

greenheart/tools/profast_tools.py

…ts too

…o dev/lcoh_fix

jaredthomas68

Good progress, I noticed a few more things we really should fix. I'm sorry I did not notice them on my initial review.

jaredthomas68 · 2025-02-07T16:13:52Z

greenheart/simulation/technologies/hydrogen/electrolysis/pem_cost_tools.py

+            )
+
+    def calc_simple_refurb_schedule(self):
+        annual_performance = self.electrolyzer_physics_results["H2_Results"][


jaredthomas68 · 2025-02-07T16:14:04Z

greenheart/simulation/technologies/hydrogen/electrolysis/pem_cost_tools.py

+        return refurb_simple
+
+    def calc_complex_refurb_schedule(self):
+        annual_performance = self.electrolyzer_physics_results["H2_Results"][


jaredthomas68 · 2025-02-07T16:14:18Z

greenheart/simulation/technologies/hydrogen/electrolysis/pem_cost_tools.py

+        return refurb_complex
+
+    def make_lifetime_utilization(self):
+        annual_performance = self.electrolyzer_physics_results["H2_Results"][


jaredthomas68 · 2025-02-07T16:14:30Z

greenheart/simulation/technologies/hydrogen/electrolysis/pem_cost_tools.py

+
+
+def calc_electrolyzer_variable_om(electrolyzer_physics_results, greenheart_config):
+    electrolyzer_config = greenheart_config["electrolyzer"]


jaredthomas68 · 2025-02-07T16:14:42Z

greenheart/simulation/technologies/hydrogen/electrolysis/pem_cost_tools.py

+
+@define
+class ElectrolyzerLCOHInputConfig:
+    """C


It looks like the description did not get saved. Please include the description along with any relevant citations if necessary.

jaredthomas68 · 2025-02-07T20:28:32Z

greenheart/tools/profast_tools.py

+    """Make a custom price breakdown of primary cost items in $/unit of commodity.
+
+    Args:
+        price_breakdown (pd.DataFrame): price breakdown generated by ProFAST


The breakdown here does not match the breakdown that comes directly from profast. Can you provide more explanation on why and what this function is doing?

jaredthomas68 · 2025-02-07T20:29:51Z

tests/greenheart/input_files/plant/greenheart_config.yaml

@@ -13,6 +13,7 @@ project_parameters:
  hybrid_electricity_estimated_cf: 0.492 #should equal 1 if grid_connection = True
  atb_year: 2025
  cost_year: 2022 # to match ATB
+  # installation_time: 0 #36 # months


As noted above, let's keep this input since we need it unless running ORBIT and I don't want a hidden hard-coded default somewhere in the code. Could set to "orbit" to use the value that is calculated by orbit

jaredthomas68 · 2025-02-07T20:32:03Z

tests/greenheart/test_hydrogen/test_PEM_costs_custom.py

+)
+
+
+TOL = 1e-3


This tolerance is pretty loose, I would suggest going with <=1E-6 unless there is a good reason not to

jaredthomas68 · 2025-02-07T20:35:05Z

tests/greenheart/test_openmdao.py

@@ -441,4 +441,4 @@ def test_run_greenheart_optimize(subtests):
    lcoh_final = case.get_val("lcoh", units="USD/kg")[0]

    with subtests.test("lcoh"):
-        assert lcoh_final < lcoh_init
+        assert lcoh_final <= lcoh_init


This is testing the optimization function and should stay as <

what is it trying to optimize? the greenheart config input file (tests/greenheart/input_files/plant/greenheart_config_onshore.yaml) is missing opt_options.

It is minimizing LCOH wrt the electrolyzer rating. The optimization stuff is added in the setup_greenheart function called at the beginning of the test.

jaredthomas68 · 2025-02-07T20:35:48Z

tests/greenheart/test_openmdao_mpi.py

@@ -205,4 +205,4 @@ def test_run_greenheart_optimize_mpi(subtests):
        lcoh_final = case.get_val("lcoh", units="USD/kg")[0]

        with subtests.test("lcoh"):
-            assert lcoh_final < lcoh_init
+            assert lcoh_final <= lcoh_init


Should stay as <

kbrunik · 2025-02-17T16:56:13Z

greenheart/simulation/technologies/hydrogen/electrolysis/pem_cost_tools.py

+            if self.electrolyzer_config["complex_refurb"]:
+                use_complex_refurb = True
+
+        # complex schedule assumes stacks are replaced in the year they reach EOL


can we spell out end-of-life? make it easier for people not hip with the lingo

kbrunik · 2025-02-17T16:56:53Z

greenheart/simulation/technologies/hydrogen/electrolysis/pem_cost_tools.py

+            "Performance Schedules"
+        ]
+
+        #: electrolyzer system capacity in kW


There's a mix of units in parentheses and some in text, maybe pick one for consistency?

kbrunik · 2025-02-17T16:59:06Z

greenheart/simulation/technologies/hydrogen/electrolysis/pem_cost_tools.py

+            * annual_performance["Annual Average Efficiency [kWh/kg]"].values
+        )
+
+        if "analysis_start_year" not in greenheart_config["finance_parameters"]:


Adding a note here, since I agree with @jaredthomas68. I think we should throw an error if these aren't set in the greenheart config

kbrunik · 2025-02-17T17:48:34Z

greenheart/simulation/technologies/hydrogen/electrolysis/pem_cost_tools.py

+    electrolyzer_eff_kWh_pr_kg: list[float] = field(init=False)
+    electrolyzer_annual_h2_production_kg: list[float] = field(init=False)
+
+    # simple_replacement_schedule: list[float] = field(init=False)


Remove commented out code?

kbrunik · 2025-02-17T17:49:16Z

greenheart/tools/eco/finance.py

+import greenheart.tools.profast_tools as pf_tools
+
+
+# from greenheart.simulation.technologies.hydrogen.electrolysis.pem_cost_tools import (


remove commented out import?

kbrunik · 2025-02-17T17:52:58Z

greenheart/tools/eco/finance.py

To the extend that you'd be willing to add docstrings to this file that would be awesome since most of the methods are undocumented here. No need to add to the functions you don't modify but the ones you are adding/changing maybe you could document

kbrunik · 2025-02-17T17:56:25Z

greenheart/tools/eco/finance.py

@@ -658,7 +682,9 @@ def run_profast_lcoe(
    pf.set_params("maintenance", {"value": 0, "escalation": gen_inflation})
    pf.set_params("analysis start year", greenheart_config["project_parameters"]["atb_year"] + 1)
    pf.set_params("operating life", greenheart_config["project_parameters"]["project_lifetime"])
-    pf.set_params("installation months", wind_cost_results.installation_time)
+    pf.set_params(


Using the greeneheart config to set the "installation_time" removes the ability to set the installation time from ORBIT. Maybe in the run_wind_cost_model() function we need to change it so if greenheart_config["project_parameters"]["installation_time"] is not set that it uses the ORBIT output and logs the change? @jaredthomas68 thoughts?

kbrunik · 2025-02-17T18:39:26Z

A broader comment on the PR. @elenya-grant would you be able to add a note about why the test results are changing?

Also, I think it's fine to leave the "unused profast tools", I believe some of them are used in the electrowinning work that is going to be brought in here in the next few weeks.

elenya-grant added 2 commits January 31, 2025 15:38

updated lcoh calc for to be more aligned with GS methodology

85c663d

fixed circular import error with electrolyzer cost tools

7d28785

elenya-grant requested a review from jaredthomas68 January 31, 2025 23:20

elenya-grant added 5 commits January 31, 2025 16:59

ran formatter on new file

35cc318

ran formatter on modified files

f7f00c1

formatted

a500504

actually fixed for tests

5fe5173

updated tests with new values

6c5188e

jaredthomas68 requested changes Feb 4, 2025

View reviewed changes

johnjasa and others added 17 commits February 4, 2025 11:36

Merge branch 'develop' into dev/lcoh_fix

166b44a

modified adjust_dollar_year to be able to take in dictionaries or lis…

76c543b

…ts too

updated electrolyzer cost tools integrated variable om

19e38c2

updated example input files

1038f8b

updated test input files for test_greensteel

61a1a6b

Merge branch 'dev/lcoh_fix' of github.com:elenya-grant/GreenHEART int…

d3dfe11

…o dev/lcoh_fix

added test for custom PEM cost function

b869798

changed input for custom pem cost

b299828

update test input file

1d4c105

adjusted openmdao test assert

90c63dc

added profast_reverse_tools functions

375e7c9

added some docstrings to new functions

fc7b32e

added more doc strings to profast tools

8c91b8f

updated input file to fix tests

59d1d26

updated doc strings and refurb period in electrolyzer output config

51a983f

moved setting default installation time to setup_greenheart

39bbc1a

Merge branch 'develop' into dev/lcoh_fix

2382eee

jaredthomas68 requested changes Feb 7, 2025

View reviewed changes

kbrunik reviewed Feb 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LCOH Update and Custom Electrolyzer Costs #79

LCOH Update and Custom Electrolyzer Costs #79

elenya-grant commented Jan 31, 2025

jaredthomas68 left a comment

jaredthomas68 Feb 3, 2025

elenya-grant Feb 5, 2025

jaredthomas68 Feb 3, 2025

elenya-grant Feb 5, 2025

jaredthomas68 Feb 4, 2025

jaredthomas68 Feb 4, 2025

jaredthomas68 Feb 4, 2025

jaredthomas68 left a comment

jaredthomas68 Feb 7, 2025

jaredthomas68 Feb 7, 2025

jaredthomas68 Feb 7, 2025

jaredthomas68 Feb 7, 2025

jaredthomas68 Feb 7, 2025

jaredthomas68 Feb 7, 2025

jaredthomas68 Feb 7, 2025

jaredthomas68 Feb 7, 2025

jaredthomas68 Feb 7, 2025

elenya-grant Feb 10, 2025

jaredthomas68 Feb 10, 2025

jaredthomas68 Feb 7, 2025

kbrunik Feb 17, 2025

kbrunik Feb 17, 2025

kbrunik Feb 17, 2025

kbrunik Feb 17, 2025

kbrunik Feb 17, 2025

kbrunik Feb 17, 2025

kbrunik Feb 17, 2025

kbrunik commented Feb 17, 2025

		import numpy as np


		def summarize_electrolysis_cost_and_performance(electrolyzer_physics_results, electrolyzer_config):

		return sol, summary, price_breakdown


		def make_price_breakdown(price_breakdown, pf_config):



		def calc_electrolyzer_variable_om(electrolyzer_physics_results, greenheart_config):
		electrolyzer_config = greenheart_config["electrolyzer"]

		import greenheart.tools.profast_tools as pf_tools


		# from greenheart.simulation.technologies.hydrogen.electrolysis.pem_cost_tools import (

		)


		TOL = 1e-3

LCOH Update and Custom Electrolyzer Costs #79

Are you sure you want to change the base?

LCOH Update and Custom Electrolyzer Costs #79

Conversation

elenya-grant commented Jan 31, 2025

Update to LCOH script and added custom electrolyzer cost functionality.

PR Checklist

Related issues

Impacted areas of the software

Additional supporting information

Test results, if applicable

jaredthomas68 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaredthomas68 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kbrunik commented Feb 17, 2025