Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure label naming #85

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Figure label naming #85

merged 4 commits into from
Feb 20, 2025

Conversation

jaredthomas68
Copy link
Collaborator

@jaredthomas68 jaredthomas68 commented Feb 13, 2025

Figure label naming

This PR changes figure text to use sentence case and also switches all internal and plotting uses of "metric tonne" and "tonne" to "metric ton".

PR Checklist

  • CHANGELOG.md has been updated to describe the changes made in this PR
  • Documentation
    • Docstrings are up-to-date
    • [-] Related docs/ files are up-to-date, or added when necessary
    • [-] Documentation has been rebuilt successfully
    • Examples have been updated
  • Tests pass (If not, and this is expected, please elaborate in the tests section)
  • PR description thoroughly describes the new feature, bug fix, etc.

Related issues

Impacted areas of the software

  • examples/reference_plants/01-onshore-steel-mn/onshore-steel-mn.py
  • greenheart/simulation/technologies/hydrogen/desal/desal_model_eco.py
  • greenheart/simulation/technologies/hydrogen/electrolysis/pem_mass_and_footprint.py
  • greenheart/simulation/technologies/hydrogen/h2_storage/pressure_vessel/compressed_gas_storage_model_20221021/Compressed_all.py
  • greenheart/simulation/technologies/hydrogen/h2_storage/pressure_vessel/compressed_gas_storage_model_20221021/Compressed_gas_function.py
  • greenheart/simulation/technologies/offshore/fixed_platform.py
  • greenheart/simulation/technologies/offshore/floating_platform.py
  • greenheart/simulation/technologies/steel/steel.py
  • greenheart/tools/eco/electrolysis.py
  • greenheart/tools/eco/finance.py
  • greenheart/tools/eco/hydrogen_mgmt.py
  • greenheart/tools/eco/utilities.py
  • tests/greenheart/test_hydrogen/test_pressure_vessel.py

Additional supporting information

The catalyst for this change was feedback from the NREL communications team during review of the green steel reference system design document.

Test results, if applicable

@jaredthomas68 jaredthomas68 changed the base branch from main to develop February 13, 2025 17:56
@kbrunik kbrunik self-requested a review February 17, 2025 16:14
@johnjasa
Copy link
Collaborator

Non-blocking question: I see there are still places that are relatively external facing (.ipynb examples) where we say "tonnes". Did you leave those in on purpose or should those be changed as part of this PR? To be clear, I don't care to update any references in the to_organize folder.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jaredthomas68
Copy link
Collaborator Author

jaredthomas68 commented Feb 17, 2025

Non-blocking question: I see there are still places that are relatively external facing (.ipynb examples) where we say "tonnes". Did you leave those in on purpose or should those be changed as part of this PR? To be clear, I don't care to update any references in the to_organize folder.

I intended to only leave "tonnes" in places where it would be breaking (e.g. calling dependencies that use "tonnes"). I had ignored the to_organize directory, but the others I had missed by not search .ipynb or .md extensions. Thanks for the catch. I went ahead and updated everything non-breaking (e.g. input files for ORBIT)

@johnjasa johnjasa merged commit 5c0f80f into NREL:develop Feb 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants