make battery heuristic general so other generation tech besides wind and pv can use the heuristic #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and pv can be used
genevievestarke
approved these changes
Oct 22, 2024
…o feature/generalize-dispatch
RHammond2
reviewed
Oct 22, 2024
| @@ -674,12 +674,12 @@ def simulate_with_dispatch( | |||
|
|
|||
| def battery_heuristic(self): | |||
| tot_gen = [0.0] * self.options.n_look_ahead_periods | |||
There was a problem hiding this comment.
Could this be simplified to the following?
tot_gen = np.zeros(self.options.n_look_ahead_periods)
for power_source in self.power_sources.keys():
if "battery" in power_source or "grid" in power_source:
continue
tot_gen += self.power_sources[power_source].dispatch.available_generationThere was a problem hiding this comment.
Yes and done
There was a problem hiding this comment.
It looks like this is missing from above the for loop: tot_gen = np.zeros(self.options.n_look_ahead_periods). If you iteratively add a list, it'll just be a really long list.
There was a problem hiding this comment.
Good catch. I'm not sure numpy will work without having knock-on effects, but I'll try it
RHammond2
reviewed
Oct 22, 2024
tests/hopp/test_dispatch.py
Outdated
| wave_resource_file = ROOT_DIR / "simulation" / "resource_files" / "wave" / "Wave_resource_timeseries.csv" | ||
|
|
||
| desired_schedule=desired_schedule = 8760*[20] |
There was a problem hiding this comment.
Looks like there is an extra desired_schedule= here.
There was a problem hiding this comment.
Thanks, fixed
RHammond2
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and pv can be used
Generalize heuristic load following to any gen tech
This PR allows any technology to be dispatched with the load following heuristic, not just wind and pv.
Related issue
Impacted areas of the software
hopp/simulation/technologies/dispatch/hybrid_dispatch_builder_solver.pyAdditional supporting information
This came up while working on the profast financial model and needs to get merged in prior to the financial model work
Test results, if applicable
Passing