Clean up type_dec.py #382
Merged
Clean up type_dec.py #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bayc
added
enhancement
bayc
force-pushed
the
feature/clean_up_type_dec
branch
from
c65c06a
to
e3154eb
Compare
|
I might be missing it, but are there meaningful changes to the warning messages here? just looks like formatting changes |
No, but I've requested @jaredthomas68 to add the changes he originally wanted. Just trying to clean up some of the old issues and got the ball rolling here. |
jaredthomas68
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up
type_dec.pyThis PR removes extraneous import statements and improves the error message around resource file paths. This was originally identified as an issue by @jaredthomas68 .
TODO:
Related issue
Closes #328
Impacted areas of the software
type_dec.pyAdditional supporting information
None.
Test results, if applicable
None.