-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Tidy the plotting library #253
Enhancement: Tidy the plotting library #253
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop_v3 #253 +/- ##
==============================================
+ Coverage 61.85% 65.50% +3.64%
==============================================
Files 29 29
Lines 4315 4061 -254
==============================================
- Hits 2669 2660 -9
+ Misses 1646 1401 -245 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thanks for adding more flexibility to plot.plot_by_id
and using that in the yaw misalignment example!
This PR brings the entire
openoa/utils/plot.py
up to spec with later implemented best practices to ensure that figures can be customized in the methods to suit most needs for publication or presentation, or return the matplotlib objects back to add the final touches.Given that
plot_windfarm
was added at a later point in time and is much cleaner,plot_array
has been deprecated entirely. However, the following have been removed as a byproduct of their original intent being lost and their usage being unclear:This PR closes #251.