Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Tidy the plotting library #253

Merged
merged 10 commits into from
Sep 25, 2023

Conversation

RHammond2
Copy link
Collaborator

This PR brings the entire openoa/utils/plot.py up to spec with later implemented best practices to ensure that figures can be customized in the methods to suit most needs for publication or presentation, or return the matplotlib objects back to add the final touches.

Given that plot_windfarm was added at a later point in time and is much cleaner, plot_array has been deprecated entirely. However, the following have been removed as a byproduct of their original intent being lost and their usage being unclear:

  • plot_array
  • subplot_powerRose_array
  • powerRose_array
  • subplot_c1_c2
  • subplot_c1_c2_flagged
  • subplot_c1_c2_raw_flagged
  • subplt_power_curve
  • turbine_polar_line
  • turbine_polar_4Dscatter
  • turbine_polar_contourf
  • turbine_polar_contour

This PR closes #251.

@RHammond2 RHammond2 added enhancement v3 All updates and changes for OpenOA v3 labels Sep 14, 2023
@RHammond2 RHammond2 added this to the V3.0 milestone Sep 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2023

Codecov Report

Attention: Patch coverage is 8.33333% with 22 lines in your changes missing coverage. Please review.

Project coverage is 65.50%. Comparing base (daf42ac) to head (371c4f2).

Files with missing lines Patch % Lines
openoa/utils/plot.py 8.33% 22 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           develop_v3     #253      +/-   ##
==============================================
+ Coverage       61.85%   65.50%   +3.64%     
==============================================
  Files              29       29              
  Lines            4315     4061     -254     
==============================================
- Hits             2669     2660       -9     
+ Misses           1646     1401     -245     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ejsimley ejsimley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks for adding more flexibility to plot.plot_by_id and using that in the yaw misalignment example!

openoa/utils/plot.py Outdated Show resolved Hide resolved
@RHammond2 RHammond2 merged commit 2807556 into NREL:develop_v3 Sep 25, 2023
2 checks passed
@RHammond2 RHammond2 deleted the enhancement/cleanup-plotting branch September 25, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement v3 All updates and changes for OpenOA v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants