Split HPWHs #1172
Draft
Split HPWHs #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split HPWHs
Addresses #1170. Adding functionality to model split HPWHs. Two products will be modeled in the initial implementation: A Chinese AO Smith split HPWH and a SanCO2. The Chinese unit is coming to the US market soon and uses the same refrigerant as integrated HPWHs (with refrigerant being circulated), while the SanCO2 uses CO2 and circulates water.
Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
EPvalidator.xml) has been updatedtasks.rb)HPXMLtoOpenStudio/tests)openstudio tasks.rb update_measureshas been run