Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MJ blower fan heat and piping inputs #1751

Merged
merged 6 commits into from
Jun 17, 2024
Merged

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Jun 14, 2024

Pull Request Description

Addresses #1721.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit added the enhancement New feature or request label Jun 14, 2024
@shorowit shorowit self-assigned this Jun 14, 2024
@shorowit shorowit mentioned this pull request Jun 14, 2024
10 tasks
shorowit and others added 5 commits June 14, 2024 17:17
…o mj_blower_heat_and_piping

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	HPXMLtoOpenStudio/tests/test_hvac_sizing.rb
…o mj_blower_heat_and_piping

# Conflicts:
#	Changelog.md
#	HPXMLtoOpenStudio/measure.xml
@shorowit shorowit marked this pull request as ready for review June 17, 2024 22:19
@shorowit shorowit merged commit d5a3942 into master Jun 17, 2024
7 checks passed
@shorowit shorowit deleted the mj_blower_heat_and_piping branch June 17, 2024 23:26
@joseph-robertson joseph-robertson mentioned this pull request Jul 11, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant