-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After Tax Savings and Updates to Results Table Spreadsheet #631
Open
Bill-Becker
wants to merge
27
commits into
develop
Choose a base branch
from
after-tax-savings
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the GHX residual value
bpulluta
reviewed
Mar 6, 2025
reoptjl/custom_table_config.py
Outdated
@@ -323,8 +329,8 @@ | |||
{ | |||
"label" : "Total Electric Costs ($)", | |||
"key" : "total_electric_utility_costs", | |||
"bau_value" : lambda df: safe_get(df, "outputs.Financial.lifecycle_elecbill_after_tax_bau"), | |||
"scenario_value": lambda df: safe_get(df, "outputs.Financial.lifecycle_elecbill_after_tax") | |||
"bau_value" : lambda df: safe_get(df, "outputs.Financial.lifecycle_elecbill_after_tax_bau") - safe_get(df, "outputs.Financial.lifecycle_export_benefit_after_tax_bau") + safe_get(df, "outputs.CHP.lifecycle_chp_standby_cost_after_tax_bau"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want this to show the formula I would reformulate this, like this for example:
- Set these to empty strings
"label" : "Total Electric Costs ($)",
"key" : "total_electric_utility_costs",
"bau_value": lambda df: "",
"scenario_value": lambda df: ""
- Define the values in the table:
"label" : "Lifecycle Export After Tax ($)",
"key" : "lifecycle_export_after_tax",
"bau_value": lambda df: "outputs.Financial.lifecycle_export_benefit_after_tax_bau",
"scenario_value": lambda df: "outputs.Financial.lifecycle_export_benefit_after_tax"
"label" : "CHP Lifecycle Standby Cost After Tax($)",
"key" : "chp_lifecycle_export_after_tax",
"bau_value": lambda df: "outputs.CHP.lifecycle_chp_standby_cost_after_tax_bau",
"scenario_value": lambda df: "outputs.CHP.lifecycle_chp_standby_cost_after_tax"
- Add it as a formula like this:
"name": "Total Electric Costs ($)",
"formula": lambda col, bau, headers: f'={col}{headers["Lifecycle Export After Tax ($)"] + 2}+{col}{headers["CHP Lifecycle Standby Cost After Tax($)"] + 2}'
didnt focus too much on accuracy but you get the point, same with the others
bpulluta
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bunch of year one after-tax cost outputs and one capital cost output that were added to REopt.jl#after-tax-savings (to be merged into the main branch), and then adds a select number of those outputs along with some updates to the results table spreadsheet to calculate a modified after-tax payback. See the attached example comparison_table.xlsx doc with a highlight of the additions and updates to the table.
comparison_table Example for PR with Notes.xlsx
Not related to the above, this also includes a fix for cooling load:
monthly_fraction
in thesimulated_load
function injulia_src/http.jl
.(For reference, this is what GitHub Copilot autogenerated for the PR)
This pull request includes several changes to the
docker-compose.yml
,julia_src/Manifest.toml
,julia_src/http.jl
, andreoptjl/custom_table_config.py
files. The changes primarily focus on updating configurations, modifying commands, and enhancing the table configurations with new fields and calculations.Key Changes:
Configuration Updates:
docker-compose.yml
file to use a new command for the Julia project instantiation and execution.Dependency Management:
julia_src/Manifest.toml
file to include new repository information for theREopt
dependency.Code Enhancements:
monthly_fraction
in thesimulated_load
function injulia_src/http.jl
.Table Configuration Enhancements:
reoptjl/custom_table_config.py
file to include after-tax costs and savings, as well as additional financial metrics. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]