Update poetry to 1.8.3 #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anyaelena
approved these changes
May 10, 2024
| @@ -38,7 +38,7 @@ influxdb = "^5.3.1" | |||
| # required for tests to pass right now. There are often issues when pinning to a branch | |||
| # and calling poetry update. I have had to completely remove my venv and reinstall in order | |||
| # to get the latest updates. | |||
| alfalfa-client = { git = "https://github.com/nrel/alfalfa-client.git", branch = "upload_model_check" } | |||
| alfalfa-client = { git = "https://github.com/nrel/alfalfa-client.git", branch = "develop" } | |||
There was a problem hiding this comment.
when does this get re-aligned with dev?
There was a problem hiding this comment.
do you mean with a release of alfalfa_client?
everytime an API change is made the client has to change, so usually I wait until it's time to release the new version of alfalfa to release the new client so that people's setups don't break by automatically installing incompatible versions of the alfalfa client.
Additionally, this package inclusion is only used for testing so it doesn't really affect anyone besides us. The reason it was set to the upload_model_check branch instead of dev for a while was because there were changes made in the client to fix a breaking bug that hadn't been merged yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as I was going through the dependency updates from dependabot I was having issues with failing package installs and really long dependency resolution times. I decided to upgrade to the latest version of poetry and that seems to have fixed all of the problems I was having.