Fix DatetimeRange timestamp iteration #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixiliu
changed the title
daniel-thom
reviewed
Nov 12, 2024
src/chronify/time_configs.py
Outdated
| @@ -184,14 +185,22 @@ def is_time_zone_naive(self) -> bool: | |||
| return self.start.tzinfo is None | |||
|
|
|||
| def list_timestamps_from_dataframe(self, df: pd.DataFrame) -> list[datetime]: | |||
| return df[self.time_column].to_list() | |||
| return df[self.time_column].drop_duplicates().to_list() | |||
There was a problem hiding this comment.
It needs to be sorted. I did that in #16
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 94.20% 94.24% +0.03%
==========================================
Files 18 18
Lines 777 782 +5
==========================================
+ Hits 732 737 +5
Misses 45 45 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
DatetimeRange.iter_timestamps()does not return the correct time series when the starting timestamp is tz-aware and in a timezone with DST.Currently the function produces the following at spring-forward:
It needs to be:
Solution: Advance timestamp in standard timezone (e.g., UTC) and convert back to input timezone before yielding.
Also fixed
DatetimeRange.list_timestamps_from_dataframe()to return unique timestamps only. Do we need sort it?Did not fix relevant pytests