Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visualization #140

Open
wants to merge 5 commits into
base: fastsim-2
Choose a base branch
from
Open

visualization #140

wants to merge 5 commits into from

Conversation

bijay079
Copy link
Collaborator

@bijay079 bijay079 commented Jun 27, 2024 •
edited by calbaker
Loading

@kylecarow
Copy link
Collaborator

@calbaker I think you're familiar with how to resolve the failure above, it is to do with numpy versions i think

@calbaker
Copy link
Collaborator

calbaker commented Jul 1, 2024

@kylecarow , I just pushed code that should fix the problem

kylecarow
kylecarow approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@kylecarow kylecarow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This should be a super useful starting framework for plotting. I like the descriptive names for the variables!

python/fastsim/plot_module.py Show resolved Hide resolved
python/fastsim/plot_module.py Show resolved Hide resolved
python/fastsim/plot_module.py Outdated Show resolved Hide resolved
python/fastsim/plot_module.py Show resolved Hide resolved
python/fastsim/plot_module.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarow kylecarow kylecarow approved these changes

@calbaker calbaker Awaiting requested review from calbaker

@jakeholden jakeholden Awaiting requested review from jakeholden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bijay079 @kylecarow @calbaker