Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F3/interp with benchmarking #146

Closed
wants to merge 96 commits into from
Closed

F3/interp with benchmarking #146

wants to merge 96 commits into from

Conversation

calbaker
Copy link
Collaborator

@calbaker calbaker commented Jul 24, 2024 •
edited
Loading

  • feature gated logging to fix performance problems. We're targeting 10x faster than fastsim-2, but with inactive, compiled logging, we get about 0.7x of fastsim-2 speed. After feature gating, we're about 8x faster when not saving and 4x faster when saving

  • wrote but did not use macro that should be able to log function duration

  • this PR might include everything in N-dimensional interpolation #127, but is not meant to usurp that PR, which should proceed when @robinsteuteville finishes applying the Interpolator everywhere.

  • finalize when N-dimensional interpolation #127 is complete

kylecarow and others added 30 commits May 14, 2024 16:20
@kylecarow
WIP interpolation enum and module
5e91602
@kylecarow
support 0-D (constant) interpolation in multilinear
ef4f329
@kylecarow
WIP commit
33e095f
@kylecarow
add short-circuiting to interpolation
f282081
@kylecarow
added 2d and 3d interpolation and short circuiting
ce46e73
@kylecarow
interp reorg
b8afe99
@kylecarow
N-D is working, woohoo
a46c572
@kylecarow
bug fix for 3d, more test coverage
3bb6eb2
@kylecarow
remove benchmark stuff
f167670
@kylecarow
add dummy test for github actions CI
ea0f0f1
@kylecarow
benchmarks are now more practical
1ca3e36
@kylecarow
simplify anyhow::ensure calls
f6957a1
@kylecarow
moved validation checks that should only happen once
15a0341
@kylecarow
switch to binary search and rework unwraps into with_context
f39c4aa
@kylecarow
Merge branch 'fastsim-3' into f3/interpolation
a68de0d 
# Conflicts:
#	fastsim-core/Cargo.toml
@kylecarow
complete benchmarks for other dimensionalities
1412dc2
@kylecarow
add phantomdata to prevent direct construction outside interp mod
d019b1d
@kylecarow
add comments to phantom fields
a3f63b5
@kylecarow
remove efficiency enum and multilinear util
1cab25e
@kylecarow
restructure interpolation and add extrapolation
165195e
@kylecarow
add tests for extrapolation
9bb2f3e
@kylecarow
warn to info
b4d328b
@kylecarow
min to [0], max to * .last()
0467142
@kylecarow
add docstrings and log::warn! about using N-D interpolator when n <= 3
7fbe477
@kylecarow
WIP wrapper enum
88f7e30
@robinsteuteville
working on adding getters and setters for InterpolatorWrapperVec
4065d9e
@calbaker
conventional plots are looking good
9ac23f1
@calbaker
removed jupyter notebook
2dffb81
@calbaker
deleted deprecated comment
db68275
@calbaker
fixed color/linestyle cycler
305ef95 
optionally saves plots
other formatting
robinsteuteville and others added 23 commits July 23, 2024 12:37
@robinsteuteville
creating demos for all interpolation types
7dac92a
@robinsteuteville
trying to get setters working
e6c8f82
@robinsteuteville
another attempt at having the setters work
771bc0b
@robinsteuteville
updating comments and cleaning things up
461750f
@calbaker
changed order for readabality
241fc5b
@calbaker
Merge branch 'f3/cpu-perf-troubleshooting' into f3/interp-with-benchm…
bc567da 
…arking

# Conflicts:
#	python/fastsim/demos/demo.ipynb
@robinsteuteville
making serde skip phantom field
6e6696e
@calbaker
Merge branch 'f3/interpolation' of github.com:NREL/fastsim into f3/in…
5df0fef 
…terp-with-benchmarking
@calbaker
updated to match other file with same contents
b83bd6f
@calbaker
allows Tuple structs without the word Vec in the name
980c372
@calbaker
allows Tuple structs without the word Vec in the name
8fba96e
@calbaker
Merge branch 'f3/interpolation' of github.com:NREL/fastsim into f3/in…
d018a7c 
…terp-with-benchmarking
@calbaker
clippy hints
7189247
@calbaker
Merge branch 'f3/interpolation' into f3/interp-with-benchmarking
a0e820d
@calbaker
created timer proc macro for timing functions
63431dd
@calbaker
feature gated logging and made it off by default
bccd12d
@calbaker
first and probably last commit
4f216e7
@calbaker
removed this file because it's deprecated
4131e86
@calbaker
improved prints
6e947e8
@calbaker
clippy hints
2136439
@calbaker
added no save check, too
d36a307
@calbaker
made an environment var for saving figures
bee5aaf
@calbaker
propagated SAVE_FIGS exhaustively
83007b1
@calbaker calbaker marked this pull request as draft August 8, 2024 20:35
@calbaker calbaker mentioned this pull request Aug 8, 2024
Merged
6 tasks
@calbaker
Copy link
Collaborator Author

superseded by #150

@calbaker calbaker closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calbaker @kylecarow @robinsteuteville