make sure points are created with trace CRS #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the end/start points of trajectory segments to be joined were re-interpreted as coordinates in XY_CRS. This is wrong if the underlying trace (and map) is not in XY_CRS.
nreinicke
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the end/start points of trajectory segments to be joined were always interpreted in
XY_CRS. If the underlying trace (and map) are not inXY_CRS, this re-interpreted the points inXY_CRS, leading toshortest_pathto reject the points due to mismatch between the coordinatesXY_CRSand the actual CRS of map and trace.