SDG data designer providers addition#197
Open
rapaul-nv wants to merge 3 commits into
Open
Conversation
Signed-off-by: Rakesh Paul <rapaul@nvidia.com>
Signed-off-by: Rakesh Paul <rapaul@nvidia.com>
Signed-off-by: Rakesh Paul <rapaul@nvidia.com>
58465ce to
321f71c
Compare
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
providers:support tosdg/data_designerso configs can register custom Data Designer model providers.models[].providerto target either a built-in provider such asnvidiaor a custom provider declared in YAML.customer_support_tools.yaml.Notes
providers[].api_keyshould be an environment variable name such asOPENAI_API_KEY, not${oc.env:OPENAI_API_KEY}, so Data Designer resolves the secret at request time instead of materializing it in the compiled config.Validation
uv run pytest tests/steps/sdg/test_data_designer.pyuv run ruff check src/nemotron/steps/sdg/data_designer/step.py tests/steps/sdg/test_data_designer.pyproviders[].nameis registered andmodels[].providerselects that provider.