Skip to content

Conversation

@yuzhongw-nvidia
Copy link
Contributor

@yuzhongw-nvidia yuzhongw-nvidia commented Oct 31, 2025

What does this PR do ?

torch.compile is not very well supported on Blackwell, and may cause Qwen3-Next hanging when training on Blackwell. Add a flag in arguments to disable it.

With triton>=3.4.0, this fix PR, and the following extra arguments, the issue will be resolved.

  --disable-jit-fuser \
  --no-bias-gelu-fusion \
  --no-bias-swiglu-fusion \
  --no-bias-dropout-fusion

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either [email protected] or [email protected].

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@yuzhongw-nvidia yuzhongw-nvidia requested review from a team as code owners October 31, 2025 04:06
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 31, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yuzhongw-nvidia yuzhongw-nvidia changed the base branch from main to dev October 31, 2025 04:08
@yuzhongw-nvidia yuzhongw-nvidia removed request for a team October 31, 2025 04:08
@yuzhongw-nvidia
Copy link
Contributor Author

/ok to test 9a2ce88

@yuzhongw-nvidia
Copy link
Contributor Author

/ok to test 6a68816

@yuzhongw-nvidia yuzhongw-nvidia force-pushed the fix_qwen3next_blackwell branch from 6a68816 to 158e53b Compare October 31, 2025 04:17
@yuzhongw-nvidia
Copy link
Contributor Author

/ok to test 158e53b

@yanring yanring added this pull request to the merge queue Nov 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 6, 2025
@BestJuly BestJuly added this pull request to the merge queue Nov 6, 2025
Merged via the queue into NVIDIA:dev with commit 6cc224d Nov 6, 2025
43 checks passed
yuzhongw-nvidia added a commit to yuzhongw-nvidia/Megatron-LM that referenced this pull request Nov 7, 2025
yuzhongw-nvidia added a commit to yuzhongw-nvidia/Megatron-LM that referenced this pull request Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants