Skip to content

Conversation

tgasser-nv
Copy link
Collaborator

@tgasser-nv tgasser-nv commented Sep 2, 2025

Description

This top-level PR combines all the Sub-PRs at the module-level into a single PR that can be merged and rebased against.

Sub-PRs

  • actions : 146 errors, 0 warnings, 0 informations. PR1361
  • actions_server : 2 errors, 0 warnings, 0 informations: PR1379
  • cli : 38 errors, 0 warnings, 0 informations: PR1380
  • colang : 113 errors, 0 warnings, 0 informations: PR1381
  • embeddings : 31 errors, 0 warnings, 0 informations: PR1383
  • eval : 91 errors, 0 warnings, 0 informations (P1 as it's an offline evaluation tool)
  • evaluate : 52 errors, 4 warnings, 0 informations (P1 as it's an offline evaluation tool)
  • integrations : 21 errors, 0 warnings, 0 informations: PR1384
  • kb : 2 errors, 0 warnings, 0 informations: PR1385
  • library : 142 errors, 0 warnings, 0 informations: PR1389
  • llm : 49 errors, 1 warning, 0 informations: PR1394
  • logging : 28 errors, 0 warnings, 0 informations: PR1395
  • rails : 82 errors, 0 warnings, 0 informations: PR1396
  • server : 20 errors, 0 warnings, 0 informations PR1397
  • tracing : 5 errors, 1 warning, 0 informations: PR1388

Related Issue(s)

Checklist

  • I've read the CONTRIBUTING guidelines.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • @mentions of the person or team responsible for reviewing proposed changes.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.62%. Comparing base (960e0b8) to head (71d00f0).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1367   +/-   ##
========================================
  Coverage    71.62%   71.62%           
========================================
  Files          171      171           
  Lines        17020    17020           
========================================
  Hits         12191    12191           
  Misses        4829     4829           
Flag Coverage Δ
python 71.62% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
nemoguardrails/actions/llm/generation.py 85.96% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tgasser-nv
Copy link
Collaborator Author

tgasser-nv commented Sep 9, 2025

Note to self before merging:

  • Need to replace # pyright: ignore with # type: ignore which is a PEP standard and generalizes to other type-checkers other than Pyright
  • Check for any if type(obj) == ClassName and replace with the more general if isinstance(obj, ClassName) which is inheritance-aware

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants