-
Notifications
You must be signed in to change notification settings - Fork 403
[JAX] grouped_gemm() uses variadic arguments #1658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
phu0ngng
merged 14 commits into
NVIDIA:main
from
huanghua1994:JAX-GroupedGEMM-VariadicArgs
Apr 14, 2025
Merged
[JAX] grouped_gemm() uses variadic arguments #1658
phu0ngng
merged 14 commits into
NVIDIA:main
from
huanghua1994:JAX-GroupedGEMM-VariadicArgs
Apr 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9b9aef
to
600029a
Compare
phu0ngng
reviewed
Apr 10, 2025
600029a
to
3af8804
Compare
/te-ci jax L0 |
5d581ee
to
292f7a9
Compare
phu0ngng
reviewed
Apr 10, 2025
phu0ngng
reviewed
Apr 10, 2025
phu0ngng
reviewed
Apr 10, 2025
Signed-off-by: Hua Huang <[email protected]>
Signed-off-by: Hua Huang <[email protected]>
Signed-off-by: Hua Huang <[email protected]>
Signed-off-by: Hua Huang <[email protected]>
Signed-off-by: Hua Huang <[email protected]>
Signed-off-by: Hua Huang <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Hua Huang <[email protected]>
Signed-off-by: Hua Huang <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Hua Huang <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Hua Huang <[email protected]>
292f7a9
to
c850c00
Compare
/te-ci jax L0 |
Pipeline #26823920 passed. |
phu0ngng
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes the
grouped_gemm()
implementation in JAX. The original implementation manually flattens all input matrices before lowering to C++ function and manually split the output into a list of tensors. Using variadic arguments allows the code to avoid extra copying of inputs and outputs.This PR is marked as a draft since PR #1545 breaks both the original implementation and this implementation for MXFP8 on Blackwell.Fixed by PR #1652.Type of change
Changes
Rewrite
grouped_gemm()
andGroupedGemmPrimitive
using variadic arguments.Checklist: