Skip to content

[Common] Add checks to CUDA kernel launch and CUDA API calls #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yaox12
Copy link
Member

@yaox12 yaox12 commented Aug 14, 2025

Description

Ensure checks are added to CUDA kernel launch and CUDA API calls

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@yaox12 yaox12 force-pushed the xiny/ensure_cuda_check branch from df8ec3b to 58718ee Compare August 14, 2025 09:24
@yaox12
Copy link
Member Author

yaox12 commented Aug 14, 2025

/te-ci

Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be very useful. We've definitely been sloppy about error checking.

@timmoon10
Copy link
Collaborator

/te-ci

@yaox12
Copy link
Member Author

yaox12 commented Aug 15, 2025

Many normalization tests are failing. The failed Python tests are probably caused by normalizations as well, or reported asynchronously due to previous errors. cc @timmoon10

@timmoon10
Copy link
Collaborator

/te-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants