[PyTorch Debug] Fix issue with microbatching + debug value caching #2108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pawel Gadzinski <[email protected]>
|
/te-ci pytorch |
ptrendx
reviewed
Aug 26, 2025
| @@ -1460,7 +1460,13 @@ def is_debug_iter(self) -> bool: | |||
| debug = False | |||
| else: | |||
| debug = TEDebugState.get_iteration() >= self.next_iter_when_debug_should_be_run | |||
| self.debug_last_iteration = TEDebugState.get_iteration() | |||
| self.debug_last_iteration = TEDebugState.get_iteration() | |||
| self.debug_enabled_in_last_iteration = debug | |||
There was a problem hiding this comment.
Why not call it then "debug_enabled_in_this_iteration"?
Signed-off-by: Pawel Gadzinski <[email protected]>
|
/te-ci pytorch |
…ansformerEngine into nvinspect_fix_performance_issue
|
/te-ci pytorch |
1 similar comment
|
/te-ci pytorch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #1909 I introduced debug value caching, to prevent expensive cpu calls which used to determine if debug should be disabled. They do not work correctly with microbatching. This PR fixes that.
Fixes # (issue)
Type of change
Checklist: