[PyTorch Debug] Support precision debug tools for fp8 model parameters. #2141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently precision debug tools are not supported for FP8 model parameters. It is because all logic of debug tools is inside quantize() function in DebugQuantizers, which are not called if weight is in FP8. Also, for some stats like number of underflows we need both high precision tensor and quantized tensor.
I added function
DebugQunatizer.wrap_quantized_tensor(QuantizedTensor) -> DebugQuantizedTensor
which will be called for debug iterations for weight. The debug for all the other tensors work without any change.I made argument
tensor
forinspect_tensor
call optional - it is None for weight tensor in case of fp8 model parameters.If one wants to use LogTensorStats, the quantized tensor is dequantized. For LogFp8TensorStats the stats which needs high precision tensor are disabled in considered case.
Fixes #2140
Type of change
Checklist: