Implement the new tuning API for deterministic (rfa) reduce dispatch#7346
Open
bernhardmgruber wants to merge 5 commits intoNVIDIA:mainfrom
Open
Implement the new tuning API for deterministic (rfa) reduce dispatch#7346bernhardmgruber wants to merge 5 commits intoNVIDIA:mainfrom
bernhardmgruber wants to merge 5 commits intoNVIDIA:mainfrom
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
30 tasks
797e34a to
1962a21
Compare
Contributor
Author
|
/ok to test 1962a21 |
This comment has been minimized.
This comment has been minimized.
1962a21 to
ffd700d
Compare
Comment on lines
47
to
53
| #if !TUNE_BASE | ||
| cub::detail::rfa::dispatch<input_it_t, output_it_t, int, init_t, transform_t, accum_t, policy_selector_t>( | ||
| nullptr, temp_storage_bytes, d_in, d_out, elements, {}, 0); | ||
| #else | ||
| cub::detail::rfa::dispatch<input_it_t, output_it_t, int, init_t, transform_t, accum_t>( | ||
| nullptr, temp_storage_bytes, d_in, d_out, elements, {}, 0); | ||
| #endif |
Contributor
There was a problem hiding this comment.
Perhaps is preprocessor to define auto rfa_dispatch differently based on TUNE_BASE and use that throughout to reduce branching?
Suggested change
| #if !TUNE_BASE | |
| cub::detail::rfa::dispatch<input_it_t, output_it_t, int, init_t, transform_t, accum_t, policy_selector_t>( | |
| nullptr, temp_storage_bytes, d_in, d_out, elements, {}, 0); | |
| #else | |
| cub::detail::rfa::dispatch<input_it_t, output_it_t, int, init_t, transform_t, accum_t>( | |
| nullptr, temp_storage_bytes, d_in, d_out, elements, {}, 0); | |
| #endif | |
| #if !TUNE_BASE | |
| auto rfa_dispatch = cub::detail::rfa::dispatch<input_it_t, output_it_t, int, init_t, transform_t, accum_t, policy_selector_t>; | |
| #else | |
| auto rfa_dispatch = cub::detail::rfa::dispatch<input_it_t, output_it_t, int, init_t, transform_t, accum_t>; | |
| #endif | |
| rfa_dispatch(nullptr, temp_storage_bytes, d_in, d_out, elements, {}, 0); |
Then similarly for the actual invocation few lines below.
Contributor
Author
There was a problem hiding this comment.
That's an interesting suggestion, but if I take the address of the template instantiation of dispatch when I need to later provide all function arguments (defaults no longer work). I didn't know that! I refactored it differently now.
The test was wrong but always passed because the rfa dispatcher ignored CUB_DETAIL_DEFAULT_KERNEL_LAUNCHER_FACTORY since it was hardcoded to triple_chevron.
972031c to
adcb7fd
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
😬 CI Workflow Results🟥 Finished in 2h 44m: Pass: 98%/99 | Total: 22h 42m | Max: 2h 44m | Hits: 99%/108245See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cub.bench.reduce.deterministic.baseon SM75/SM86/SM90