Add (failing) tests demonstrating that errors in Buffer.close are not raised #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok to test 845fbd4 |
1 task
|
Andy-Jost
force-pushed
the
ipc_suppressed_errors
branch
from
845fbd4 to
adfb7e5
Compare
|
/ok to test 0986f5e |
Andy-Jost
force-pushed
the
ipc_suppressed_errors
branch
from
0986f5e to
78a4815
Compare
|
/ok to test 1d5248e |
Andy-Jost
added
test
Andy-Jost
force-pushed
the
ipc_suppressed_errors
branch
from
1d5248e to
bbdbbcd
Compare
Andy-Jost
changed the title
Andy-Jost
force-pushed
the
ipc_suppressed_errors
branch
from
d916308 to
b7f8c2a
Compare
…ple) are not raised.
Andy-Jost
force-pushed
the
ipc_suppressed_errors
branch
from
6e9c283 to
fea6f8a
Compare
rwgk
reviewed
Oct 10, 2025
| mr.close() | ||
|
|
||
|
|
||
| @pytest.mark.xfail |
There was a problem hiding this comment.
Will this work here?
@pytest.mark.xfail(reason="Issue #1118", strict=True)
The important part is strict=True.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors occurring during
Buffer.closeare not raised. This change adds tests demonstrating the issue. See #1118.