Generalize inc, dec, and test kernels to support arbitrary number of qubits.#28
Open
ToroData wants to merge 2 commits intoNVIDIA:mainfrom
Open
Generalize inc, dec, and test kernels to support arbitrary number of qubits.#28ToroData wants to merge 2 commits intoNVIDIA:mainfrom
ToroData wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Refactored inc_with_n_qubits to infer qubit length dynamically. Corrected dec and test kernels to remove argument mismatches. Signed-off-by: Ricard Santiago Raigada García <ricardraigada@outlook.es>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes kernel argument issues and generalizes the
inc_with_n_qubits,dec, andtestkernels to work with any number of qubits, eliminating fixed-size constraints and runtime errors.Original Issue
Attempting to run the original implementation triggered the following compiler error from CUDA Q:
Changes
inc_with_n_qubits(qubits)now derives its size internally vialen(qubits).dec(qubits)correctly usescudaq.adjoint(...)with a single argument.test(binary_list)was updated to removenum_qubitsand infer size from the list.License
I affirm that this contribution is submitted under the Apache License 2.0 for source code and is compliant with the developer certificate of origin.
Signed-off-by: Ricard Santiago Raigada García ricardraigada@outlook.es