Fix PyTriton library discovery #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishi Chandra <[email protected]>
eordentlich
approved these changes
Feb 27, 2025
| # Add nvidia_pytriton.libs to LD_LIBRARY_PATH | ||
| for path in sys.path: | ||
| if os.path.isdir(path) and "site-packages" in path: | ||
| libs_path = os.path.join(path, "nvidia_pytriton.libs") |
There was a problem hiding this comment.
This shouldn't be needed and seems like a bug in the py triton python package
There was a problem hiding this comment.
For libpython3.*.so at least they do instruct to add to path in conda envs per docs. But yeah linking pytriton libs seems like it shouldn't be necessary; will ping on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect and configure required library paths (i.e., to Triton bundled libraries and libpython3.*.so), when starting Triton process. Avoids the need to set executorEnv globally and works across conda/non-conda envs (e.g. Dataproc vs. Databricks).
Minor cleanups to PyTriton server shutdown.