Fix AvalancheCenterSelectorModal Error State#1139
Merged
kevinherdez merged 1 commit intoNWACus:mainfrom Mar 31, 2026
Merged
Conversation
yuliadub
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue I ran into when I didn't have good reception. It's possible for the network calls used by the
AvalancheCenterSelectorModalto fail while the map loads fine. This causes the error state for the modal to be shown even if the modal isn't shownThe fix moves the error state inside the modal itself so that it's only rendered, if the modal needs to be rendered (based off the
visibleandloadingflags)Error inside the modal
I also cleaned up the modal in general:
SafeAreaProviderandSafeAreaViewin favor ofsafeAreaInsetsthat was already being used in the viewView. TheVStacktaking up 100% of the height fills the view by itselfViewthat was needed "to paint the very bottom of the screen white". I just changed the background colors in the content so I could achieve the same effect