Skip to content

Fix AvalancheCenterSelectorModal Error State #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinherdez wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix AvalancheCenterSelectorModal Error State #1139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 32 additions & 39 deletions components/modals/AvalancheCenterSelectionModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
import React, {useCallback, useState} from 'react';
import {ScrollView, StyleSheet} from 'react-native';
import {ScrollView} from 'react-native';

import Topo from 'assets/illustrations/topo.svg';
import {avalancheCenterList, AvalancheCenters} from 'components/avalancheCenterList';
import {AvalancheCenterList} from 'components/content/AvalancheCenterList';
import {Button} from 'components/content/Button';
import {incompleteQueryState, QueryState} from 'components/content/QueryState';
import {Center, Divider, View, VStack} from 'components/core';
import {Center, Divider, VStack} from 'components/core';
import {Body, BodyBlack, Title3Black} from 'components/text';
import {useAllAvalancheCenterMetadata} from 'hooks/useAllAvalancheCenterMetadata';
import {useAvalancheCenterCapabilities} from 'hooks/useAvalancheCenterCapabilities';
import {Modal} from 'react-native';
import {SafeAreaProvider, SafeAreaView, useSafeAreaInsets} from 'react-native-safe-area-context';
import {useSafeAreaInsets} from 'react-native-safe-area-context';
import {colorLookup} from 'theme';
import {AvalancheCenter, AvalancheCenterID} from 'types/nationalAvalancheCenter';

Expand Down Expand Up @@ -40,44 +40,37 @@ export const AvalancheCenterSelectionModal: React.FC<AvalancheCenterSelectionMod
}
const safeAreaInsets = useSafeAreaInsets();

if (incompleteQueryState(capabilitiesResult, ...metadataResults) || !capabilities) {
return <QueryState results={[capabilitiesResult, ...metadataResults]} />;
}

return (
<Modal transparent visible={visible && !loading} animationType="slide" onRequestClose={closeHandler}>
<SafeAreaProvider>
<View style={{...StyleSheet.absoluteFillObject, backgroundColor: colorLookup('primary.background')}}>
<SafeAreaView style={{width: '100%', height: '100%'}}>
{/* view to paint the very bottom of the screen white */}
<View style={{position: 'absolute', left: 0, right: 0, bottom: 0, height: safeAreaInsets.bottom, backgroundColor: 'white'}} />
{/* overflow hidden to keep the topo illustration from going beyond this view */}
<VStack justifyContent="space-between" height="100%" overflow="hidden">
{/* these magic numbers are yanked out of Figma */}
<Topo width={887.0152587890625} height={456.3430480957031} style={{position: 'absolute', left: -264, top: 338}} />
<VStack space={16} pt={96} px={16} flex={1}>
<Center px={32}>
<Title3Black textAlign="center" color={colorLookup('NWAC-dark')}>
Welcome! Get started by selecting your local avalanche center.
</Title3Black>
</Center>
<Center px={32} pb={32}>
<Body textAlign="center">You can change this anytime in settings.</Body>
</Center>
<ScrollView>
<AvalancheCenterList selectedCenter={selectedCenter} setSelectedCenter={setSelectedCenter} data={avalancheCenterList(metadata, capabilities)} />
</ScrollView>
</VStack>
<Divider />
<Center height={100} width="100%" px={16} backgroundColor={'white'} alignItems="stretch">
<Button disabled={!selectedCenter} onPress={closeHandler} buttonStyle="primary" mt={16}>
<BodyBlack>Continue</BodyBlack>
</Button>
</Center>
</VStack>
</SafeAreaView>
</View>
</SafeAreaProvider>
{incompleteQueryState(capabilitiesResult, ...metadataResults) || !capabilities ? (
// We want to show the query state as a part of the modal so that it only shows when the modal is present
<QueryState results={[capabilitiesResult, ...metadataResults]} />
) : (
// overflow hidden to keep the topo illustration from going beyond this view
<VStack justifyContent="space-between" height="100%" overflow="hidden" paddingBottom={safeAreaInsets.bottom} backgroundColor={colorLookup('white')}>
{/* these magic numbers are yanked out of Figma */}
<Topo width={887.0152587890625} height={456.3430480957031} style={{position: 'absolute', left: -264, top: 338}} />
<VStack space={16} pt={96} px={16} flex={1} backgroundColor={colorLookup('primary.background')}>
<Center px={32}>
<Title3Black textAlign="center" color={colorLookup('NWAC-dark')}>
Welcome! Get started by selecting your local avalanche center.
</Title3Black>
</Center>
<Center px={32} pb={32}>
<Body textAlign="center">You can change this anytime in settings.</Body>
</Center>
<ScrollView>
<AvalancheCenterList selectedCenter={selectedCenter} setSelectedCenter={setSelectedCenter} data={avalancheCenterList(metadata, capabilities)} />
</ScrollView>
</VStack>
<Divider />
<Center height={100} width="100%" px={16} backgroundColor={'white'} alignItems="stretch">
<Button disabled={!selectedCenter} onPress={closeHandler} buttonStyle="primary" mt={16}>
<BodyBlack>Continue</BodyBlack>
</Button>
</Center>
</VStack>
)}
</Modal>
);
};
Loading