Allocate default_material in the MPI shared_memory when copy Numpy arrays to meep
#2221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2221 +/- ##
==========================================
- Coverage 73.24% 73.20% -0.05%
==========================================
Files 17 17
Lines 4897 4904 +7
==========================================
+ Hits 3587 3590 +3
- Misses 1310 1314 +4
|
|
Do you want to try fixing the pre-commit errors? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to discussion 2158 This is a possible way in which the memory is not copied multiple times per process, and leverages the use of the MPI shared memmory capabilities to reduce the memory consumption. In the example code showed in the discussion 2158, it was possible to increase the number of process running the simulation from 8 to 24 in a single node, since the memory consumption is reduced.