Skip to content

Conversation

@oskooi
Copy link
Collaborator

@oskooi oskooi commented Oct 8, 2023

Fixes #2665.

Requires a (working) SWIG wrapper and a unit test.

@codecov-commenter
Copy link

Codecov Report

Merging #2670 (1cf5550) into master (e908ef8) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #2670      +/-   ##
==========================================
- Coverage   73.81%   73.81%   -0.01%     
==========================================
  Files          18       18              
  Lines        5294     5296       +2     
==========================================
+ Hits         3908     3909       +1     
- Misses       1386     1387       +1     
Files Coverage Δ
python/simulation.py 77.04% <50.00%> (-0.03%) ⬇️

@oskooi
Copy link
Collaborator Author

oskooi commented Oct 12, 2023

Turns out this feature is more challenging to implement than I originally thought because add_near2far does not center its DFT fields on the Yee-grid voxels unlike add_flux (see #2538 (comment) for more details). This is why the Poynting flux calculation in add_flux is trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DftNear2Far class contains no member function to compute Poynting flux of its near/monitor fields

2 participants