-
Notifications
You must be signed in to change notification settings - Fork 730
Update SSP with erosions/dilations #3087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Here we update the SSP algorithm to handle erosion and dilations functions.
|
@stevengj I have the following test for our new erosion and dilation feature:
It's obviously not quite there yet. I'm not sure how to tackle the following challenge: we only use our level-set approximation to identify the boundaries themselves. Anything not on a boundary, we fall back to our brute-force tanh_projection output (hence the It seems that in order to do erosions/dilations, we really have to use the level-set across the whole domain, right? |
|
Your code doesn't seem right? Let's consider the |
|
Let me make an alternative suggestion.
|
|
@stevengj ok so that indeed produces an erosion or dilation:
We should do some experiments to show that the resulting transformation really reflects what the user prescribed, and doesn't depend e.g. on the "steepness" of the filtered field like |
|
As a test, you could compare it to non-differentiable morphological open/close operations (maybe even setting To avoid being too sensitive to discretization effects during testing, you'll probably want to make Ideally the difference with morphological operations should go to zero as the resolution increases ( |


Here we update the SSP algorithm to account for the following features/fixes:
resolution_simulationparameter to account for differences in meep and design grid resolutions(cc @oskooi, @stevengj )