Reset queryParameterString when the current session doesn't have a query. #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ery. In HTTP 1.1, connection is reused across HTTP connection (aka HTTP session in nanohttpd). See the connection reuse codes in ClientHandler where HTTPSession is reused by calling execute() in a while loop. However, in HTTPSession, queryParameterString is not cleaned up correctly across sessions when a previous session has a query while the current one doesn't have a query. This results in the incorrect caching of queryParameterString. The fix is to ensure queryParameterString is initialized to an empty string when the current session's URI does not contain a query component. The bug is reproduced with nanohttpd + okhttp which is also used to validate the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In HTTP 1.1, connection is reused across HTTP connection (aka HTTP session in nanohttpd). See the connection reuse codes in ClientHandler where HTTPSession is reused by calling execute() in a while loop.
However, in HTTPSession, queryParameterString is not cleaned up correctly across sessions when a previous session has a query while the current one doesn't have a query. This results in the incorrect caching of queryParameterString.
The fix is to ensure queryParameterString is initialized to an empty string when the current session's URI does not contain a query component.
The bug is reproduced with nanohttpd + okhttp which is also used to validate the fix.