Skip to content

Make ServerRunnable fields volatile for thread safety #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+3 −3
Open

Make ServerRunnable fields volatile for thread safety #658

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a9d373
Make fields volatile for thread safety
maxcai314 Oct 26, 2025
03351fb
Re-interrupt thread instead of ignoring InterruptedException
maxcai314 Oct 26, 2025
6892f24
:Revert "Re-interrupt thread instead of ignoring InterruptedException"
maxcai314 Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/src/main/java/org/nanohttpd/protocols/http/ServerRunnable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@
*/
public class ServerRunnable implements Runnable {

private NanoHTTPD httpd;
private final NanoHTTPD httpd;

private final int timeout;

private IOException bindException;
private volatile IOException bindException;

private boolean hasBinded = false;
private volatile boolean hasBinded = false;

public ServerRunnable(NanoHTTPD httpd, int timeout) {
this.httpd = httpd;
Expand Down